Skip to content

ci: keep telemetry failures out of the fetch job status - #107

Merged
okisdev merged 1 commit into
mainfrom
ci/telemetry-guard
Aug 31, 2026
Merged

ci: keep telemetry failures out of the fetch job status#107
okisdev merged 1 commit into
mainfrom
ci/telemetry-guard

Conversation

@okisdev

@okisdev okisdev commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

problem

the telemetry step runs under the workflow's fail-fast shell: a GitHub API outage, empty commit list, or date parse failure exits the if: always() step non-zero and marks the whole fetch job failed, contradicting the step's warning-only degradation design (flagged by review on #103).

change

guard the freshness computation: a failed gh api or unparseable date degrades to dataAgeHours: -1 ("unknown") instead of killing the step. -1 can never false-trigger the planned > 48h staleness monitor.

verification

yaml lints clean; the ingest call already degrades to a workflow warning.

Track in Rupic

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modelpedia-web Ready Ready Preview Aug 31, 2026 5:54am

@rupic-app

rupic-app Bot commented Aug 31, 2026

Copy link
Copy Markdown

Comment Reviewed in 6m 3s · Round 1 · comment · fef1d64

Merge as is — freshness lookup failures degrade without failing the fetch job

This PR should merge as-is because the base workflow runs its GitHub API lookup and date conversion inside an if: always() step at .github/workflows/fetch-models.yml:178-187, so either failure can turn warning-only telemetry into a failed fetch job. The added guard confines those failures to dataAgeHours=-1, preserves the valid-date calculation, and does not duplicate an existing repository primitive. I found no blocking correctness, side-effect, convention, parity, or governance issue.

Worth noting, not blocking

Merge state: The latest state reports the PR open, non-draft, and mergeable. Eight of nine checks have completed, with seven successful and one neutral; one check remains in progress. No gating human review or unresolved review thread is reported.

Evidence · 1 verified · 3 not verified

Verified

  • The ingest call already degrades to a workflow warning.
    The existing ingest command explicitly handles failure with a warning-only fallback.

Not verified

  • A failed gh api or unparseable date degrades to dataAgeHours: -1 instead of failing the step.
    The fallback is visible in the diff, but an executed workflow or shell harness with injected gh and date failures is needed to establish the resulting job status.
  • -1 can never false-trigger the planned > 48h staleness monitor.
    The sentinel is numerically below 48, but the planned monitor is not implemented in this checkout; its actual comparison is not available to verify end to end.
  • The YAML lints clean.
    A YAML-lint result is not present in the available PR check state, so the claim cannot be independently established here.

Read the full changed workflow, exact diff, base workflow, sibling Axiom workflow, root contribution rules, package scripts, repository-wide related identifiers, and available PR state and comments. No tests, workflow runs, or PR code were executed. One non-blocking test-coverage conclusion was recorded; no prior review findings or threads were present.

Round Commit Verdict Took When
1 fef1d64 comment 6m 3s 2026-08-31 05:59 UTC

Comment @rupic-app stop reviewing to stop reviewing this PR.

Review by Rupic.

@rupic-app rupic-app Bot added stage/needs-review No reviews yet; waiting for a maintainer R1 Actionable, normal priority type/chore Tooling, deps, CI, formatting size/XS Fewer than 10 lines changed labels Aug 31, 2026
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
modelpedia-api fef1d64 Commit Preview URL

Branch Preview URL
Aug 31 2026, 05:54 AM

@rupic-app rupic-app Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 inline comment below, on .github/workflows/fetch-models.yml.

Full review: #107 (comment)

Comment thread .github/workflows/fetch-models.yml
@rupic-app rupic-app Bot added stage/awaiting-reviewer Has reviews but not approved; reviewer follow-up needed and removed stage/needs-review No reviews yet; waiting for a maintainer labels Aug 31, 2026
@okisdev
okisdev merged commit 1988cf5 into main Aug 31, 2026
11 checks passed
@okisdev
okisdev deleted the ci/telemetry-guard branch August 31, 2026 06:04
@rupic-app rupic-app Bot added stage/merged Merged into the default branch and removed stage/awaiting-reviewer Has reviews but not approved; reviewer follow-up needed R1 Actionable, normal priority labels Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Fewer than 10 lines changed stage/merged Merged into the default branch type/chore Tooling, deps, CI, formatting

Development

Successfully merging this pull request may close these issues.

1 participant