Skip to content

Conversation

@JakeLane
Copy link
Contributor

@JakeLane JakeLane commented Nov 13, 2025

Motivation

The benchmark exits in CI when a regression is detected, which means we don't report the comment https://github.com/atlassian-labs/atlaspack/actions/runs/19319920537/job/55259235723?pr=884

Changes

  • Removing the exit call on regression
  • Removed an unwanted samples arg in CI

Checklist

  • Existing or new tests cover this change
  • There is a changeset for this change, or one is not required
  • Added documentation for any new features to the docs/ folder

@JakeLane JakeLane requested a review from a team as a code owner November 13, 2025 04:46
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025

⚠️ No Changeset found

Latest commit: ef8e3d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

📊 Type Coverage Report

Coverage Comparison

Metric Baseline Current Change
Coverage Percentage 92.07% 92.07% ➡️ 0.00%
Correctly Typed 203,030 203,025 -5
Total Expressions 220,497 220,492 -5
Untyped Expressions 17,467 17,467 +0

Files with Most Type Issues (Top 15)

File Issues Affected Lines
packages/core/integration-tests/test/javascript.ts 983 648
packages/core/integration-tests/test/cache.ts 885 626
packages/core/integration-tests/test/scope-hoisting.ts 623 490
packages/utils/node-resolver-core/test/resolver.ts 476 177
packages/core/integration-tests/test/html.ts 468 294
packages/core/integration-tests/test/sourcemaps.ts 356 176
packages/core/test-utils/src/utils.ts 330 205
packages/core/integration-tests/test/incremental-bundling.ts 298 206
packages/core/core/src/dumpGraphToGraphViz.ts 251 108
packages/core/integration-tests/test/output-formats.ts 227 161
packages/transformers/webextension/src/WebExtensionTransformer.ts 210 80
packages/core/integration-tests/test/css-modules.ts 191 107
packages/core/core/src/requests/TargetRequest.ts 190 133
packages/core/integration-tests/test/react-refresh.ts 188 65
packages/core/integration-tests/test/babel.ts 187 115

This report was generated by the Type Coverage GitHub Action

@JakeLane JakeLane enabled auto-merge (squash) November 13, 2025 04:51
@JakeLane JakeLane disabled auto-merge November 13, 2025 04:52
@JakeLane JakeLane enabled auto-merge (squash) November 13, 2025 05:04
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

📊 Benchmark Results

⚠️ Performance regressions detected!

📊 Benchmark Results

Overall Performance

Test Duration JS Memory Peak Native Memory Peak vs Baseline Status
Three.js Real Repository (JS) 17.70s 1.95GB 2.15GB +7.19% duration, -5.88% JS memory 🔴 Regression
Three.js Real Repository (V3) 31.91s 3.66GB 4.08GB N/A ⚪ New

🔍 Detailed Phase Analysis

Three.js Real Repository (JS)

Phase Duration (avg) Duration (p95) Memory Peak (avg) Memory Peak (p95)
resolving 9.26s 9.88s 1.42GB 1.77GB
transforming 9.25s 9.88s 1.43GB 1.77GB
bundling 9.04s 9.65s 1.43GB 1.78GB
bundled 8.64s 9.27s 1.53GB 1.89GB
packaging 6.13s 6.47s 1.64GB 1.98GB
optimizing 5.96s 6.33s 1.95GB 2.23GB

Three.js Real Repository (V3)

Phase Duration (avg) Duration (p95) Memory Peak (avg) Memory Peak (p95)
bundling 20.72s 28.58s 2.91GB 3.35GB
bundled 20.23s 28.15s 3.09GB 3.53GB
packaging 12.46s 26.08s 3.28GB 3.77GB
optimizing 7.83s 8.43s 3.66GB 4.08GB

💾 Unified Memory Analysis

Three.js Real Repository (JS) Memory Statistics

Memory Type Metric Min Mean Median P95 P99 Max Std Dev
JavaScript RSS 1.26GB 1.80GB 1.84GB 2.23GB 2.23GB 2.23GB 262.50MB
Heap Used 79.79MB 86.46MB 81.48MB 102.66MB 102.66MB 102.66MB 8.17MB
Heap Total 96.10MB 129.03MB 129.61MB 175.35MB 175.35MB 175.35MB 28.11MB
External 38.88MB 101.17MB 105.95MB 173.02MB 173.02MB 173.02MB 64.45MB
Native (Rust) Physical Memory 1.64GB 1.81GB 1.84GB 2.00GB 2.09GB 2.15GB 124.71MB
Virtual Memory 30.19GB 30.83GB 30.86GB 31.04GB 31.16GB 31.22GB 173.32MB

Sample Counts: JS: 14, Native: 296

Three.js Real Repository (V3) Memory Statistics

Memory Type Metric Min Mean Median P95 P99 Max Std Dev
JavaScript RSS 2.52GB 3.40GB 3.47GB 4.08GB 4.08GB 4.08GB 410.83MB
Heap Used 77.38MB 77.96MB 78.02MB 78.61MB 78.61MB 78.61MB 0.36MB
Heap Total 82.20MB 88.39MB 85.95MB 103.20MB 103.20MB 103.20MB 5.59MB
External 179.71MB 182.19MB 179.71MB 185.49MB 185.49MB 185.49MB 2.86MB
Native (Rust) Physical Memory 3.25GB 3.56GB 3.60GB 3.83GB 4.08GB 4.08GB 196.21MB
Virtual Memory 30.94GB 33.46GB 33.83GB 34.06GB 34.30GB 34.30GB 913.61MB

Sample Counts: JS: 14, Native: 576

🖥️ Environment

  • Node.js: v22.17.0
  • Platform: linux (x64)
  • CPU: AMD EPYC 7763 64-Core Processor
  • Total Memory: 15.62GB
  • Git SHA: ef8e3d2
  • Branch: benchmark-avoid-fail-exit-regressions
  • Timestamp: 2025-11-25T03:50:49.135Z

@JakeLane JakeLane disabled auto-merge November 13, 2025 05:12
@JakeLane JakeLane force-pushed the benchmark-avoid-fail-exit-regressions branch from 2e94d2e to ef8e3d2 Compare November 25, 2025 03:28
@JakeLane JakeLane merged commit e53f9f0 into main Nov 25, 2025
26 checks passed
@JakeLane JakeLane deleted the benchmark-avoid-fail-exit-regressions branch November 25, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants