Fix the json assertion and update the CONTRIBUTING.md guidelines #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182
Summary
The code currently uses with { type: 'json' } for importing JSON modules, which is not valid ECMAScript syntax. The correct approach is to use assert { type: 'json' } for import assertions. This change is necessary to ensure compatibility with the official module specification and modern Node.js environments (follows 20.11+ requested in CONTRIBUTING.md).
With that change, it will work better with projects when being imported by wagmi.
Also, I updated the CONTRIBUTING.md as it talked about a not exiosting
yarn buildcommand.How did you test your changes?
I built it using
yarn build:packagesand imported into an existing project using wagmi and the error from the issue dissapeared.