Skip to content

Conversation

@mjadach-iv
Copy link

@mjadach-iv mjadach-iv commented Nov 19, 2025

Fixes #182

Summary

The code currently uses with { type: 'json' } for importing JSON modules, which is not valid ECMAScript syntax. The correct approach is to use assert { type: 'json' } for import assertions. This change is necessary to ensure compatibility with the official module specification and modern Node.js environments (follows 20.11+ requested in CONTRIBUTING.md).

With that change, it will work better with projects when being imported by wagmi.

Also, I updated the CONTRIBUTING.md as it talked about a not exiosting yarn build command.

How did you test your changes?

I built it using yarn build:packages and imported into an existing project using wagmi and the error from the issue dissapeared.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 19, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@mjadach-iv mjadach-iv changed the title Bugfix/import Fix the json assertion and update the CONTRIBUTING.md guidelines Nov 19, 2025
@mjadach-iv
Copy link
Author

Just pushed a commit with a verified signature.

@chenguzhen87
Copy link

solved?

@mjadach-iv
Copy link
Author

solved?

Not yet.

Hey @spencerstock, can you please take a look at this PR?
I am tagging you here because I can see that you are the only contributor and I can't assign a reviewer to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Incorrect syntax of json assertion in @base-org/account/dist/core/constants.js:1:37

3 participants