Skip to content

Fix the json assertion and update the CONTRIBUTING.md guidelines #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix the json assertion and update the CONTRIBUTING.md guidelines #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
456c50e
change syntax of json assertion to the official ECMAScript
mjadach-iv Nov 19, 2025
ec39a72
Fix CONTRIBUTING.md with current script naming
mjadach-iv Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ First, ensure that the following are installed globally on your machine:
Then, from the root folder run:

- `yarn install` to install dependencies
- `yarn build` to build the package
- `yarn build:packages` to build the packages
- `yarn dev` to start the example app and build the package with hot reloading
- `yarn test` to ensure that the test suite runs correctly

### Navigating the codebase

The SDK is built using yarn workspaces.
The SDK is built using yarn workspaces.

- `packages/account-sdk` - The main package that exports the SDK
- `examples/test-app` - An example React app that is used to test the SDK in a real browser environment
Expand Down
2 changes: 1 addition & 1 deletion packages/account-sdk/src/core/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import pkg from '../../package.json' with { type: 'json' };
import pkg from '../../package.json' assert { type: 'json' };

export const CB_KEYS_URL = 'https://keys.coinbase.com/connect';
export const CB_WALLET_RPC_URL = 'https://rpc.wallet.coinbase.com';
Expand Down