feat: drop transferAuthorizationQueue wrapper and add DAI permit#1029
Merged
Conversation
|
|
Bumps @bosonprotocol/boson-protocol-contracts to commit ee0aaed0 and regenerates the corresponding ABIs and typechain bindings. Also bumps the boson-protocol-node and boson-subgraph docker images used by the e2e suite to the matching commit-pinned tags.
zajck
force-pushed
the
upgrade-protocol-to-2.5.1-rc.2
branch
from
May 25, 2026 13:57
befee99 to
6d1c36d
Compare
zajck
changed the title
The regenerated IBosonMetaTransactionsHandler ABI now declares transferAuthorizations as bytes[], but the SDK still wraps the queue as a single bytes via encodeTransferAuthorizationQueue. Three meta-tx tests therefore fail on this branch (which intentionally ships only the contracts/ABI bump). They are re-enabled in the follow-up PR that drops the wrapper.
zajck
force-pushed
the
upgrade-protocol-to-2.5.1-rc.2
branch
from
May 25, 2026 14:11
6d1c36d to
34fe8ca
Compare
The regenerated IBosonMetaTransactionsHandler ABI declares transferAuthorizations as bytes[], but the meta-tx-gateway image deployed for the e2e suite still expects the legacy single-bytes form. The end-to-end tests therefore fail until the gateway image is rebuilt against the new ABI. Re-enabled in the follow-up PR that drops the encodeTransferAuthorizationQueue wrapper, after the gateway rebuild.
The protocol's executeMetaTransactionWithTokenTransferAuthorization now accepts bytes[] directly, so the SDK no longer needs to wrap the list of authorization entries in an extra abi.encode(['bytes[]'], ...) layer. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Extend the SDK's TransferAuthorization strategies with the DAIPermit variant (strategy id 4). Adds: - DAIPermit case to the UnsignedTransferAuthorization union and the encodeTransferAuthorizationEntry ABI switch. - signReceiveWithDaiPermit helper that signs the DAI-style EIP-712 Permit(holder, spender, nonce, expiry, allowed) payload using the fixed DAI permit domain version "1". - Matching ERC20Mixin#signReceiveWithDaiPermit overloads. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
zajck
force-pushed
the
upgrade-protocol-to-2.5.1-rc.2
branch
from
May 25, 2026 14:44
34fe8ca to
2e4802a
Compare
The published image rebuilt against the new IBosonMetaTransactionsHandler ABI (transferAuthorizations as bytes[]). Required for the e2e meta-tx auth tests to pass after the encodeTransferAuthorizationQueue wrapper is dropped.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
- Coverage 91.78% 91.66% -0.13%
==========================================
Files 179 182 +3
Lines 7710 7764 +54
Branches 1507 1514 +7
==========================================
+ Hits 7077 7117 +40
- Misses 633 647 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
zajck
added a commit
that referenced
this pull request
May 25, 2026
Re-enables the 'meta-tx with transfer authorizations' describe block in core-sdk-token-auth.test.ts (12 tests across ERC3009/EIP2612/Permit2 × commitToOffer/commitToConditionalOffer/commitToBuyerOffer/ createOfferAndCommit) and the ERC3009 transferAuthorizations test in meta-tx.test.ts. These were left skipped on main due to a squash-merge interaction between PR #1030 (which added the skips) and PR #1029 (whose un-skips were diff'd against the pre-#1030 base and therefore collapsed to a no-op on the e2e files). Also reverts the meta-tx-gateway image tag to :main now that the bytes[] transferAuthorizations support has landed on the gateway's main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encodeTransferAuthorizationQueuewrapper:executeMetaTransactionWithTokenTransferAuthorizationnow takesbytes[]directly, so the SDK mapsTransferAuthorization[]throughencodeTransferAuthorizationEntryinstead of double-encoding.DAIPermit, id 4):signReceiveWithDaiPermithandler, ERC20 mixin overloads, and unit tests.Depends on #1030 (contracts bump + ABI regen). Merge order: #1030 → rebuild
meta-tx-gateway:mainagainst the newbytes[]ABI → this PR.Test plan
npx jest tests/erc20 tests/meta-txinpackages/core-sdk— 216 passednpm run lint:fixmeta-tx-gatewayimage (DAIPermit case included)🤖 Generated with Claude Code