fix: write failover history on the passive side #7443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidporter-id-au
force-pushed
the
bugfix/fix-failover-history-on-passive
branch
from
7133bd2 to
c4b907f
Compare
Member
Author
There was a problem hiding this comment.
refactored to EnableDomainAuditLogging
|
|
||
| // plus, we need to check whether the config version is <= the config version set in the input | ||
| // plus, we need to check whether the failover version is <= the failover version set in the input | ||
| existingDomain, err := h.domainManager.GetDomain(ctx, &persistence.GetDomainRequest{ |
Member
Author
There was a problem hiding this comment.
this gets mutated due to the substructs getting dereferenced and then edited, so it was necessary to deepcopy even though there's no actual editing of the existingDomain variable
davidporter-id-au
changed the title
davidporter-id-au
force-pushed
the
bugfix/fix-failover-history-on-passive
branch
from
c4b907f to
0df1086
Compare
davidporter-id-au
requested review from
3vilhamster,
Shaddoll,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: David Porter <[email protected]>
Signed-off-by: David Porter <[email protected]>
- Create noopDomainAuditManager to satisfy DomainAuditManager interface - Update NewReplicationTaskExecutor calls with new signature - Pass EnableDomainAuditLogging dynamic property 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: David Porter <[email protected]>
davidporter-id-au
force-pushed
the
bugfix/fix-failover-history-on-passive
branch
from
0df1086 to
16b6782
Compare
Signed-off-by: David Porter <[email protected]>
Shaddoll
reviewed
Nov 17, 2025
|
|
||
| if existingDomain.ReplicationConfig.IsActiveActive() || task.ReplicationConfig.IsActiveActive() { | ||
| mergedActiveClusters, aaChanged := mergeActiveActiveScopes(existingDomain.ReplicationConfig.ActiveClusters, task.ReplicationConfig.ActiveClusters) | ||
| if intendedDomainState.ReplicationConfig.IsActiveActive() || task.ReplicationConfig.IsActiveActive() { |
Member
There was a problem hiding this comment.
I'm confused by the places where we use intendedDomainState and other places where we use originalDomainState
Member
Author
There was a problem hiding this comment.
this is fair, let me annotate
Shaddoll
approved these changes
Nov 17, 2025
davidporter-id-au
merged commit 50ab986
into
cadence-workflow:master
57 of 58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I missed the remaining part of implementation of writing failover and domain updates to the domain audit log (the worker component just uses the manager directly rather than going to the domain handler). So this adds those logging options for passive side so that domain updates and failovers are recorded in both active and passive sides.
Unfortunately I'd not as heavily refactored the replication component, though it's fairly simple by comparison to the domain handler, so the update is fairly large.
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes