Skip to content

Commonalities v4.2 alignment#174

Merged
stroncoso merged 7 commits into
camaraproject:mainfrom
stroncoso:stroncoso/issue173
Jun 10, 2026
Merged

Commonalities v4.2 alignment#174
stroncoso merged 7 commits into
camaraproject:mainfrom
stroncoso:stroncoso/issue173

Conversation

@stroncoso

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • correction

What this PR does / why we need it:

  • Commonalities release v4.2 aligment for Sync26 release

Which issue(s) this PR fixes:

Fixes #173
Fixes #114

Special notes for reviewers:

There are a lot of additions, but all of them are formal limits, mostly taken from Commonalities

One error that we needed to fix

  • [S-016] All schemas must declare a type, so a generic "object" is added when not declared

Warnings (simple changes)

  • [S-011] All schemas must include a description --> LLM work
  • [S-312] Max length is required for strings. Some are based on commonalites, for the rest, here is my approach:
    • sink URLs: 1024
    • JWT auth: 8192
    • phoneNumber: 128
    • uuids: 36 (classic pattern 6e8bc430-9c3a-11d9-9669-0800200c9a66)
    • other WebRTC ids with pattern defined (ex.: mediaSessionId): 256
  • [S-015] PascalCase fix --> Third attempt 😅
  • [S-310] Integer type required --> assumed int32
  • [S-311] Integer max/min required --> commonalities defined
  • [S-309] Array maxItems --> commonalities defined

Changelog input

 release-note
- fix(events): Commonalites v4.2 aligment
- fix(registration): Commonalites v4.2 aligment
- fix(call-handling): Commonalites v4.2 aligment 

Additional documentation

n/a

@stroncoso stroncoso marked this pull request as ready for review June 5, 2026 23:52
@stroncoso stroncoso changed the title Stroncoso/issue173 Commonalities v4.2 alignment Jun 5, 2026

@deepakjaiswal1 deepakjaiswal1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stroncoso stroncoso merged commit 9eeca81 into camaraproject:main Jun 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commonalities v4.2 fixes PascalCase for Objects naming

2 participants