Conversation
Collaborator
Integration test reportCommit: 084d1de
Top 6 slowest tests (at least 2 minutes):
|
denik
changed the title
denik
force-pushed
the
denik/remapstate-identity-comment
branch
from
September 23, 2026 10:03
9ed6196 to
ded8289
Compare
denik
force-pushed
the
denik/remapstate-identity-comment
branch
2 times, most recently
from
September 29, 2026 12:18
4a44ba8 to
da7978d
Compare
This was referenced Sep 29, 2026
denik
force-pushed
the
denik/remapstate-identity-comment
branch
from
September 30, 2026 10:14
da7978d to
5a565ba
Compare
denik
added a commit
that referenced
this pull request
Oct 1, 2026
`ResourceSecret`'s `RemapState` mapped `value`/`owner` from the API's `effective_*` fields — needed so the persisted state matches config and re-plans show no drift — but it also zeroed the output-only metadata (`create_time`, `effective_value`, `metastore_id`, …), dropping those fields from the plan's `remote_state` display. This moves the `value`/`owner` mapping into a small in-place `remapSecretRemote` applied in `DoRead`/`DoCreate`/`DoUpdate`, and stops zeroing the rest: the output-only fields are already `ignore_remote_changes`, so they cause no drift and can flow through for visibility. `RemapState` is removed. Prep toward replacing hand-written `RemapState` with the automatic copier (#6777). This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
denik
added a commit
that referenced
this pull request
Oct 1, 2026
…6812) Surface `ForceSendFields` at the `ModelServingEndpointRemote` root and marshal via the SDK's `marshal` package, so the force-send convention is honored on the wrapper and `RemapState` becomes a plain subset copy — prep for the automatic copier (#6777). Only the per-engine `*.direct.*` plan goldens change; no action or diff changes. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
…s state type Co-authored-by: Isaac <no-reply@databricks.com>
Resources whose state type is a plain subset of the remote type had a hand-written RemapState that mechanically copied same-named fields and filtered ForceSendFields. Replace those with a copier compiled once from the (remote, state) type pair at package init and wired into the adapter when a resource has no custom RemapState. buildCopiers is driven off SupportedResources, so every auto-copied resource is validated at load: anything the copier cannot copy losslessly (kind-changing conversions, mismatched struct shapes) fails there rather than as silent drift at deploy time. Deletes 12 redundant RemapState methods; resources with genuine logic keep theirs. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Drop the duplicate reflection filler in favor of the existing fillNonZero, populating ForceSendFields with a small dedicated helper. Field-per-line table in TestSafeConvert; shorten the README section. Co-authored-by: Isaac <no-reply@databricks.com>
Move the reflection copier (compile-time type check, field/JSON-name copy, ForceSendFields filtering, lossless conversions) out of dresources into a reusable package beside structwalk/structdiff/structaccess. The direct engine wiring (buildCopiers, driven off SupportedResources) stays in dresources and now calls structcopy.Compile. Co-authored-by: Isaac <no-reply@databricks.com>
…er handles them) After the prep PRs made these dumb, the auto-generated copier reproduces them exactly (TestNoRedundantRemapState), so remove the methods. Co-authored-by: Isaac <no-reply@databricks.com>
Removes RemapState for apps, jobs, job_runs, pipelines, the postgres_* resources and quality_monitors - all plain subset copies the auto-generated copier reproduces. Only model_serving_endpoints, vector_search_indexes and secrets keep a RemapState for now; they need their own prep before the copier can take them, after which this PR (rebased) will delete them and remove the RemapState hook. Co-authored-by: Isaac <no-reply@databricks.com>
#6812 surfaced ForceSendFields at the ModelServingEndpointRemote root, making its RemapState a plain copy. The auto-copier now reproduces it exactly (TestNoRedundantRemapState), so remove the method and let buildCopiers handle it. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/remapstate-identity-comment
branch
from
October 1, 2026 13:46
5a565ba to
084d1de
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most resources'
RemapStateis a mechanical copy of same-named fields from the remote type into the state type, filteringForceSendFields. This compiles a copier per(remote, state)type pair at package init — driven offSupportedResources, so every auto-copied resource is validated at load, not as silent drift at deploy time — and wires it into the adapter when a resource has no customRemapState. Deletes 12 redundantRemapStatemethods; resources with genuine remap logic keep theirs.This pull request and its description were written by Isaac.