Skip to content

[WIP]: cythonisation#115

Draft
sroet wants to merge 5 commits into
dwhswenson:masterfrom
sroet:try_cythonizing
Draft

[WIP]: cythonisation#115
sroet wants to merge 5 commits into
dwhswenson:masterfrom
sroet:try_cythonizing

Conversation

@sroet
Copy link
Copy Markdown
Collaborator

@sroet sroet commented May 11, 2021

Here I am trying to see if we can get a speedup with cythonization of the contactobject via type hinting (as is done in for the scheduler in dask/distributed).

To run a development install with cythonization is:

python -m pip install --install-option="--with-cython" -e .

@sroet sroet marked this pull request as draft May 11, 2021 16:22
@sroet sroet mentioned this pull request May 11, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2021

Codecov Report

Merging #115 (8fbc89c) into master (aa0c46e) will decrease coverage by 1.02%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #115      +/-   ##
===========================================
- Coverage   100.00%   98.97%   -1.03%     
===========================================
  Files           13       13              
  Lines         1125     1174      +49     
===========================================
+ Hits          1125     1162      +37     
- Misses           0       12      +12     
Impacted Files Coverage Δ
contact_map/contact_map.py 97.35% <87.87%> (-2.65%) ⬇️
contact_map/contact_trajectory.py 100.00% <100.00%> (ø)
contact_map/fix_parameters.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0c46e...8fbc89c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant