fix: order status enums #377
Conversation
|
@varex83 is attempting to deploy a commit to the dYdX Trading Team on Vercel. A member of the Team first needs to authorize it. |
| - `FILLED` | ||
| - `CANCELED` | ||
| - `BEST_EFFORT_CANCELED` | ||
| - `BEST_EFFORT_OPENED` |
There was a problem hiding this comment.
This should be in oder_status enum. I have created a separate PR: #379
There was a problem hiding this comment.
is api_order_status enum even used anywhere? If not, i think we can close this pr? @varex83
There was a problem hiding this comment.
This is references ApiOrderStatus, which is located here in Rust, it contains two variants OrderStatus and BestEffortOpenedStatus, so that's why it should be here. But I think we should re-think or documentation or Rust implementation, since OrderStatus enum has BestEffortCanceled field, which, I believe, should be part of BestEffortOpenedStatus
There was a problem hiding this comment.
I see, so in that case, let's merge this one first, as it reflects whats in the rust client. We can revise this if we decide to revise the rust implementation?
There was a problem hiding this comment.
@varex83 what do you think? seems also now we have some conflicts
3 participants
Closes #376