Skip to content

fix: order status enums #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: order status enums #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions vocs-docs/docs/pages/types/api_order_status.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,9 @@

`ApiOrderStatus` is an enum consists of the following values

- `OrderStatus`
- `BestEffort`
- `OPEN`
- `FILLED`
- `CANCELED`
- `BEST_EFFORT_CANCELED`
- `BEST_EFFORT_OPENED`
Copy link
Contributor

@ndatta-nethermind ndatta-nethermind Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in oder_status enum. I have created a separate PR: #379

Copy link
Contributor

@gaonip gaonip Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is api_order_status enum even used anywhere? If not, i think we can close this pr? @varex83

Copy link
Contributor Author

@varex83 varex83 Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is references ApiOrderStatus, which is located here in Rust, it contains two variants OrderStatus and BestEffortOpenedStatus, so that's why it should be here. But I think we should re-think or documentation or Rust implementation, since OrderStatus enum has BestEffortCanceled field, which, I believe, should be part of BestEffortOpenedStatus

Copy link
Contributor

@gaonip gaonip Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so in that case, let's merge this one first, as it reflects whats in the rust client. We can revise this if we decide to revise the rust implementation?

Copy link
Contributor

@gaonip gaonip Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varex83 what do you think? seems also now we have some conflicts

- `UNTRIGGERED`
10 changes: 5 additions & 5 deletions vocs-docs/docs/pages/types/order_status.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

`OrderStatus` is an enum consists of the following values

- `Open`
- `Filled`
- `Canceled`
- `BestEffortCanceled`
- `Untriggered`
- `OPEN`
- `FILLED`
- `CANCELED`
- `BEST_EFFORT_CANCELED`
- `UNTRIGGERED`