Skip to content

Conversation

@adamretter
Copy link
Contributor

@adamretter adamretter commented May 17, 2019

See #333

Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went a head and fixed all instances of misplaced endtags so that content is actually displayed properly, added change dates to all modified articles, and cleaned up orphaned code listings.

Copy link
Member

@joewiz joewiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still references to start.jar; see http://localhost:8080/exist/apps/doc/search.html?q=start.jar:

  • Basic Installation > Launching eXist-db > Launching from the command line

    Simply calling start.jar will start eXist-db via the desktop launcher:

  • Writing Java Applications with the XML:DB API > Introduction

    There are several XML:DB examples provided in eXist's samples directory . To start an example, use the start.jar jar file and pass the name of the example class as the first parameter, for instance:

  • Basic Installation > Launching eXist-db

    Simply calling start.jar will start eXist-db via the desktop launcher:

@joewiz
Copy link
Member

joewiz commented May 18, 2019

There appear to be other instances of start.jar - the application's search engine seems not to find them all. For example, http://localhost:8080/exist/apps/doc/advanced-installation.xml#bin-executables.

@adamretter
Copy link
Contributor Author

@joewiz I used grep to find them, I think I have fixed them all now and pushed the updates.

@adamretter adamretter requested a review from joewiz May 18, 2019 14:31
@duncdrum duncdrum self-requested a review May 18, 2019 15:09
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adamretter please update the modification <date> of the articles you changed with your most recent commit.

@duncdrum
Copy link
Contributor

@joewiz about the search, if the string appears in a listing outside of the db5 file it won't get indexed, that is indeed a problem, i ll have to think about that.

@adamretter adamretter force-pushed the update-for-mavenization branch from 5298eb4 to a453b2b Compare May 18, 2019 15:32
@adamretter
Copy link
Contributor Author

@duncdrum done!

@adamretter
Copy link
Contributor Author

@joewiz thanks :-)

@adamretter
Copy link
Contributor Author

@duncdrum thanks for yours too :-)

@joewiz
Copy link
Member

joewiz commented May 19, 2019

Searching for ant turns up two more hits:

  • Configuring Database Indexes > Enabling Index Modules

Call the Ant build system once to regenerate the eXist-db libraries using build.sh or build.bat.

  • Developer's Guide to Modularized Indexes > Use case: developing an indexing architecture for GML geometries

In eXist's Git repository, the modularized Indexes code is in extensions/indexes ... The build system should normally be able to download the required libraries and build all the files automatically, in particular the extension-modules Ant target,

Also some instances of build.sh:

  • Full Text Index > Enabling the Lucene Module

    Then (re-)build eXist-db using the provided build.sh or build.bat script. The build process downloads the required Lucene jars automatically. If everything builds ok, you'll find a jar exist-lucene-module.jar in the lib/extensions directory.

  • Configuring Database Indexes > Enabling Index Modules

    Call the Ant build system once to regenerate the eXist-db libraries using build.sh or build.bat.

Several cases seem to refer to the old directory layout

@adamretter
Copy link
Contributor Author

@joewiz Okay, I sent some more updates...

@duncdrum duncdrum requested review from duncdrum May 19, 2019 11:45
@adamretter adamretter force-pushed the update-for-mavenization branch from 53eabfa to a2f02c6 Compare May 21, 2019 16:50
@duncdrum duncdrum mentioned this pull request May 22, 2019
@duncdrum
Copy link
Contributor

this CI failure is about a missing section xml:id. Future fixes should go into the 5.0.0-RC1 branch thanks.

@duncdrum duncdrum closed this May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants