-
Notifications
You must be signed in to change notification settings - Fork 862
[EuiSelectable][A11y] Search input is not read out by screen readers #9223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[EuiSelectable][A11y] Search input is not read out by screen readers #9223
Conversation
… input for better screen reader support
…focus for improved behavior
…m snapshots for improved accessibility
…o enhance accessibility
… test for improved accuracy
mgadewoll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking up this A11y fix!
I left a couple small comments for improvements, but in general the proposed update works as expected (tested in Jaws, NVDA and VoiceOver). 🎉
…roved readability
…ibility in story and docs example
This reverts commit dcdfa9c.
|
ℹ️ @jorgeoliveira117 I merged main into your branch to have it updated before merging. |
mgadewoll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 The changes work as expected and fix the A11y issue.
Thank you for contributing! 🎉
💚 Build SucceededHistory
|
💚 Build Succeeded
History
|
Closes #9161
Summary
Updates focus behavior in
EuiSelectableand ARIA attributes to match best practices. When focusing the search input, the active option remains visually focused, andaria-activedescendantis only added when an option is active.Why are we making this change?
To preserve focus: Moving focus between the search input and the item list should keep the active option visually focused, improving keyboard navigation.
ARIA compliance: aria-activedescendant should only be present when there is an active descendant. An empty string is invalid.
Screenshots
Before:
When we open the popover/dialog and focus inside the Selectable component, the first item on the list is also focused
Before.mp4
After:
When we focus inside the Selectable component, now the first item isn't focused, only the search input
After.mp4
Impact to users
🟢 No breaking changes. No code updates are required on consumer side.
ℹ️ This fix has been run in Kibana CI and required test changes have been prepared here.
✨ User value
QA
General checklist