-
Notifications
You must be signed in to change notification settings - Fork 862
[EuiSelectable][A11y] Search input is not read out by screen readers #9223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jorgeoliveira117
wants to merge
15
commits into
elastic:main
Choose a base branch
from
jorgeoliveira117:9161-euiselectable-a11y-search-input-is-not-read-out
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4998a58
fix(EuiSelectable): clear active option index when focus is on search…
jorgeoliveira117 bf47cf1
fix(EuiSelectable): remove active option index reset on search input …
jorgeoliveira117 59d3bd4
fix(EuiSelectable): remove empty aria-activedescendant attributes fro…
jorgeoliveira117 5dd142a
Merge branch 'main' into 9161-euiselectable-a11y-search-input-is-not-…
jorgeoliveira117 648849d
test(EuiSelectable): add keyboard navigation test for ArrowDown key t…
jorgeoliveira117 ffc6eac
fix(EuiFilterGroup): adjust ArrowDown key navigation in accessibility…
jorgeoliveira117 70a556e
Merge branch 'main' into 9161-euiselectable-a11y-search-input-is-not-…
jorgeoliveira117 750cbde
chore: add changelog
jorgeoliveira117 10eca7e
chore: tweak changelog
jorgeoliveira117 2ce4f0d
fix(EuiSelectable): simplify aria-activedescendant assignment for imp…
jorgeoliveira117 40c0f19
fix(EuiSelectable): add aria-label to searchProps for improved access…
jorgeoliveira117 2b4af79
Merge branch 'main' into 9161-euiselectable-a11y-search-input-is-not-…
jorgeoliveira117 dcdfa9c
fix packa name
jorgeoliveira117 f865f0c
Revert "fix packa name"
jorgeoliveira117 b5de3ca
Merge branch 'main' into 9161-euiselectable-a11y-search-input-is-not-…
mgadewoll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| **Accessibility** | ||
| - Improved the accessibility of `EuiSelectable` by removing empty `aria-activedescendant` attribute when no option is active to ensure the search input is perceivable by screen readers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.