Skip to content

add eth_subscribe and eth_unsubscribe methods#790

Closed
bomanaps wants to merge 1 commit into
ethereum:mainfrom
bomanaps:add-eth-subscribe-methods
Closed

add eth_subscribe and eth_unsubscribe methods#790
bomanaps wants to merge 1 commit into
ethereum:mainfrom
bomanaps:add-eth-subscribe-methods

Conversation

@bomanaps
Copy link
Copy Markdown
Contributor

@bomanaps bomanaps commented May 4, 2026

re-submission of @Shiti PR #331 on adding eth_subscribe / eth_unsubscribe; submitted as documentation-only since the speccheck framework can't yet validate subscription methods, deferring that testing-framework decision to core devs.

@bomanaps
Copy link
Copy Markdown
Contributor Author

bomanaps commented May 4, 2026

@fjl on the subscription-ID problem you raised, would it work to extend the .io format with a capture token (something like "result": "" on subscribe, then $subId on unsubscribe), or does speccheck really need WebSocket support landed first before any of this is testable?

cc @MysticRyuujin

@fjl
Copy link
Copy Markdown
Contributor

fjl commented May 7, 2026

We have to upgrade the spec's OpenRPC version to a newer one to be able to specify notifications.

@bomanaps
Copy link
Copy Markdown
Contributor Author

We have to upgrade the spec's OpenRPC version to a newer one to be able to specify notifications.

I have a question do you want eth_subscribe written as a pure notification method no result, or kept as a normal request/response that returns the subscription ID with a separate notification method carrying the pushed updates? and on the version itself should we target OpenRPC 1.3.x the latest open-rpc/meta-schema Go binding, v1.14.9? we can't do 1.4. it has no Go binding yet

@bomanaps
Copy link
Copy Markdown
Contributor Author

closing this #797

@bomanaps bomanaps closed this May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants