eth: add eth_subscribe and unsubscribe methods#797
Open
s1na wants to merge 1 commit into
Open
Conversation
Contributor
|
#790 what about this? |
Contributor
|
had this question #790 (comment) |
Contributor
Author
|
Ah I missed that PR. I don't mind closing it if we want to do it the proper way (by adding support to OpenRPC). |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds eth_subscribe and eth_unsubscribe for the event types: newHeads, logs, newPendingTransactions, transactionReceipts.
The schema does not enforce the binding between the event type and its arguments. OpenRPC can't express "param[1]'s shape depends on param[0]'s value" across positional params. A client could send ["newHeads", ] and still pass validation.
Fixes #496.