Set default hermes variable to SH stable, remove legacy hermes #54522
+8
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
lavenzg
force-pushed
the
export-D86885030
branch
from
2a4d3b9 to
aec5011
Compare
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Nov 13, 2025
…ook#54522) Summary: As we are moving to SH stable as default, `DEFAULT_HERMES_VARIANT` should be set to SH stable. Changelog: [Internal] Differential Revision: D86885030
lavenzg
force-pushed
the
export-D86885030
branch
from
aec5011 to
b5bd0aa
Compare
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Nov 13, 2025
…ook#54522) Summary: As we are moving to SH stable as default, `DEFAULT_HERMES_VARIANT` should be set to SH stable. Note that this will cause fantom tests to be skipped in OSS for now. Changelog: [Internal] Differential Revision: D86885030
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Nov 13, 2025
…ook#54522) Summary: As we are moving to SH stable as default, `DEFAULT_HERMES_VARIANT` should be set to SH stable. Note that this will cause fantom tests to be skipped in OSS for now. Changelog: [Internal] Differential Revision: D86885030
lavenzg
force-pushed
the
export-D86885030
branch
from
b5bd0aa to
871456f
Compare
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Nov 13, 2025
…ook#54522) Summary: As we are moving to SH stable as default, `DEFAULT_HERMES_VARIANT` should be set to SH stable. Note that this will cause fantom tests to be skipped in OSS for now. Changelog: [Internal] Differential Revision: D86885030
lavenzg
force-pushed
the
export-D86885030
branch
from
871456f to
479ca5c
Compare
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Nov 13, 2025
…ook#54522) Summary: As we are moving to SH stable as default, `DEFAULT_HERMES_VARIANT` should be set to SH stable. Note that this will cause fantom tests to be skipped in OSS for now. Changelog: [Internal] Differential Revision: D86885030
lavenzg
force-pushed
the
export-D86885030
branch
from
479ca5c to
2f41bd1
Compare
…ook#54522) Summary: As we are moving to SH stable as default, `DEFAULT_HERMES_VARIANT` should be set to SH stable. Note that this will cause fantom tests to be skipped in OSS for now. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D86885030
lavenzg
force-pushed
the
export-D86885030
branch
from
2f41bd1 to
9379eb3
Compare
🤖 Automated Code Review📊 Pull Request Review SummaryOverviewThe pull request aims to set the default Hermes variant to static Hermes stable while removing references to legacy Hermes integration. This reflects a shift in the codebase towards improved and more stable configurations for the Hermes JS engine used in React Native. 🎯 Key Findings
🔍 Detailed Issues🔴 Critical IssuesNo critical issues found. 🟠 High Priority IssuesNo high priority issues found. 🟡 Medium Priority IssuesNo medium priority issues found. 🟢 Low Priority IssuesNo low priority issues found. ✅ Positive Aspects
📝 Overall AssessmentThis pull request does not introduce any issues and appropriately aligns the code with the latest standards for using Hermes within React Native. The code changes reflect a well-considered update that enhances performance and maintainability. It is recommended to merge this pull request as it sustains high code quality and adheres to project best practices. ✅ No issues found! Code looks good.Generated by PR Review Agent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As we are moving to SH stable as default,
DEFAULT_HERMES_VARIANTshould be set to SH stable.Changelog: [Internal]
Differential Revision: D86885030