Add JSI_UNSTABLE flag #54547
Closed
Add JSI_UNSTABLE flag #54547
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We want to have a proper way of releasing new JSI features, rather than releasing into JSI as they are added. To do this, we are adding a new `JSI_UNSTABLE` flag that will gate new features. Until Hermes releases a new version, all of these "unstable" features are subject to change. Interfaces may be modified, API behavior may be changed, etc. When Hermes release a new version, the new additions will be moved out of the "unstable" status and become frozen. This diff adds the `JSI_UNSTABLE` flag to JSI and adds corresponding changes to the BUCK build. Later diffs will use this gate new APIs. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D85915163
meta-cla
bot
added
the
CLA Signed
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85915163. |
meta-codesync bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 16, 2025
Summary: X-link: facebook/react-native#54547 We want to have a proper way of releasing new JSI features, rather than releasing into JSI as they are added. To do this, we are adding a new `JSI_UNSTABLE` flag that will gate new features. Until Hermes releases a new version, all of these "unstable" features are subject to change. Interfaces may be modified, API behavior may be changed, etc. When Hermes release a new version, the new additions will be moved out of the "unstable" status and become frozen. This diff adds the `JSI_UNSTABLE` flag to JSI and adds corresponding changes to the BUCK build. Later diffs will use this gate new APIs. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D85915163 fbshipit-source-id: b2f754af4bb53db8dfe837e3ea2e2543d691754d
|
This pull request has been merged in d52b9d2. |
Collaborator
|
This pull request was successfully merged by @tsaichien in d52b9d2 When will my fix make it into a release? | How to file a pick request? |
meta-codesync bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 16, 2025
Summary: X-link: facebook/react-native#54547 We want to have a proper way of releasing new JSI features, rather than releasing into JSI as they are added. To do this, we are adding a new `JSI_UNSTABLE` flag that will gate new features. Until Hermes releases a new version, all of these "unstable" features are subject to change. Interfaces may be modified, API behavior may be changed, etc. When Hermes release a new version, the new additions will be moved out of the "unstable" status and become frozen. This diff adds the `JSI_UNSTABLE` flag to JSI and adds corresponding changes to the BUCK build. Later diffs will use this gate new APIs. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D85915163 fbshipit-source-id: b2f754af4bb53db8dfe837e3ea2e2543d691754d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We want to have a proper way of releasing new JSI features, rather than
releasing into JSI as they are added.
To do this, we are adding a new
JSI_UNSTABLEflag that will gate newfeatures. Until Hermes releases a new version, all of these "unstable"
features are subject to change. Interfaces may be modified, API behavior
may be changed, etc.
When Hermes release a new version, the new additions will be moved out
of the "unstable" status and become frozen.
This diff adds the
JSI_UNSTABLEflag to JSI and adds correspondingchanges to the BUCK build. Later diffs will use this gate new APIs.
Changelog: [Internal]
Reviewed By: lavenzg
Differential Revision: D85915163