fix: Materialize API - ODFV views not looked-up (thinks views non existant) - crashes materialize #5716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terialization logic (calling it) Signed-off-by: lukas.valatka <[email protected]>
astronautas
force-pushed
the
fix/odfv-not-found-materialize
branch
from
f2151eb to
e637eac
Compare
Contributor
Author
astronautas
force-pushed
the
fix/odfv-not-found-materialize
branch
from
ff62a9d to
f9e0de0
Compare
astronautas
changed the title
astronautas
changed the title
astronautas
changed the title
Signed-off-by: lukas.valatka <[email protected]>
astronautas
force-pushed
the
fix/odfv-not-found-materialize
branch
from
60b1e33 to
460ecdd
Compare
HaoXuAI
pushed a commit
that referenced
this pull request
Nov 12, 2025
…stant) - crashes materialize (#5716) * add pull_all_from_table_or_query for clickhouse, to align with new materialization logic (calling it) Signed-off-by: lukas.valatka <[email protected]> * fix - ensure on demand feature views can be checked too Signed-off-by: lukas.valatka <[email protected]> --------- Signed-off-by: lukas.valatka <[email protected]> Co-authored-by: Lukas Valatka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
On-demand feature views not checked when materialize is called via a web-endpoint
/materialize. Which means, ODFV cannot be materialized via an endpoint - FeatureViewNotFoundException gets raised...Solution: check
get_on_demand_feature_viewtoo!On a bigger scale, this is caused by apparently 3 different implementations of checking whether a feature view exists - logging, server and feature_store (Python SDK). I wouldn't venture into refactoring yet, since we're quite busy, but at least this bugfix unblocks ODFV materialization (which we need a lot).
Also re-organized a bit - imho we should prioritize checking features, odfvs and then stream.