mediaType for existing index #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Hildebrandt <[email protected]>
NotTheEvilOne
requested changes
Dec 17, 2024
| try: | ||
| self._check_200_response(response) | ||
| index = response.json() | ||
| # Ensure mediaType is set for existing indices |
Contributor
There was a problem hiding this comment.
I would at least encourage you to validate if a mediaType is available at the response before overwriting it. In general the method is called get_index(). Manipulating the index in this context seems like an unwanted side-effect.
Member
Author
There was a problem hiding this comment.
You're right, this should really been in update_index(). I'll also check if it's available first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement to #37 so that an existing index always gets the correct mediaType as well