Skip to content

mediaType for existing index #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eigenpaul wants to merge 1 commit into from
Closed

mediaType for existing index #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ def get_index(self, allowed_media_type: Optional[list[str]] = None):
try:
self._check_200_response(response)
index = response.json()
# Ensure mediaType is set for existing indices
Copy link
Contributor

@NotTheEvilOne NotTheEvilOne Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would at least encourage you to validate if a mediaType is available at the response before overwriting it. In general the method is called get_index(). Manipulating the index in this context seems like an unwanted side-effect.

Copy link
Member Author

@eigenpaul eigenpaul Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this should really been in update_index(). I'll also check if it's available first.

index["mediaType"] = "application/vnd.oci.image.index.v1+json"
return index

except ValueError:
Expand Down
1 change: 1 addition & 0 deletions src/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"required": [
"schemaVersion",
"manifests",
"mediaType",
],
"properties": indexProperties,
"additionalProperties": True,
Expand Down
Loading