Improve parameter validation for a number of operations where exceptions otherwise caused.#2586
Merged
Merged
Conversation
GCHQDeveloper581
changed the title
C85297
reviewed
Jun 22, 2026
C85297
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve the parameter validation, using the new framework added in #2561, for a number of operations that would otherwise throw an exception during baking.
Operations fixed:
Also tidied up a couple of outstanding linting warnings.
Existing Issues
Fixes #2448 (PseudoRandomNumberGenerator)
Fixes #2482 (BitShiftLeft)
Fixes #2484 (ToBinary)
Fixes #2487 (ToBase)
Fixes #2512 (BLAKE3)
AI disclosure
No AI used
Test Coverage
Additional tests added for BLAKE3 based on the canonical test vectors.
Parameter validation fixes are covered by existing automated parameter validation tests and adding per-operation tests would significantly increase the number of tests in the code base without providing any real added benefit.