Bump staticcheck version - #272
Conversation
…ve some unused code paths, caught by staticcheck
andydotxyz
left a comment
andydotxyz
left a comment
There was a problem hiding this comment.
In other repos I work on committing commended out code is not OK - is that acceptable here?
The other question I have is it looks like the ignores have been added in the generated output but not the generator itself, so won't they go away on next generation call?
I am really sorry, but I did not grasp the meaning of "commended out".
Fair point. I have opened go-text/typesetting-utils#29 for the generator change itself. |
A typo sorry - I meant "commented out". Normally git is sufficient to track old code if it's needed in the future. |
Ah, thank you for the clarification. I've removed the commented code. |
|
@andydotxyz friendly ping, so that we can fix the CI and publish a new tag |
andydotxyz
left a comment
andydotxyz
left a comment
There was a problem hiding this comment.
Sorry, I'm drowning in notifications, approved now
2 participants
Supersed #271, adding lint ignore directives on generated code.