go-text · benoitkugler · Sep 1, 2026 · Aug 24, 2026 · Aug 24, 2026 · Aug 27, 2026
@@ -15,7 +15,7 @@ jobs:
         go-version: 'stable'
 
     - name: Install analysis tools
-      run: go install honnef.co/go/tools/cmd/staticcheck@v0.6.0
+      run: go install honnef.co/go/tools/cmd/staticcheck@v0.8.0
 
     - name: Vet
       run: go vet ./...

@@ -9,8 +9,6 @@ import (
 	"github.com/go-text/typesetting/font/opentype/tables"
 )
 
-//go:generate ../../../../typesetting-utils/generators/binarygen/cmd/generator . _src.go
-
 // CFF2 represents a parsed 'CFF2' Opentype table.
 type CFF2 struct {
 	fdSelect fdSelect // maybe nil if there is only one font dict

@@ -6,7 +6,7 @@ import (
 	"github.com/go-text/typesetting/font/opentype/tables"
 )
 
-//go:generate ../../../../../typesetting-utils/generators/binarygen/cmd/generator . _src.go
+//go:generate ../../../typesetting-utils/generators/binarygen/cmd/generator . _src.go
 
 type header2 struct {
 	majorVersion  uint8  //	Format major version. Set to 2.

@@ -548,7 +548,6 @@ func parseValueRecord(format ValueFormat, data []byte, offset int) (out ValueRec
 				return out, 0, err
 			}
 		}
-		cursor++ // useless actually
 	}
 	return out, offset + 2*size, err
 }

@@ -296,7 +296,6 @@ func (cs *complexShaperHangul) preprocessText(_ *otShapePlan, buffer *Buffer, fo
 					i++
 					if i < end {
 						info[i].complexAux = tjmo
-						i++
 					}
 
 					buffer.mergeOutClusters(start, end)

@@ -1319,10 +1319,6 @@ func (indicPlan *indicShapePlan) finalReorderingSyllableIndic(buffer *Buffer, st
 						tmp := info[oldPos]
 						copy(info[newPos+1:], info[newPos:oldPos])
 						info[newPos] = tmp
-
-						if newPos <= base && base < oldPos {
-							base++
-						}
 					}
 				}
-Original file line number
+Diff line change
@@ Expand Up @@
     				return out, 0, err
     			}
     		}
-    		cursor++ // useless actually
     	}
     	return out, offset + 2*size, err
     }
@@ Expand Down @@