[RFC] [RFC] Split markdown rendering to a separate package. #595#647
Draft
ditman wants to merge 4 commits intogoogle:mainfrom
Draft
[RFC] [RFC] Split markdown rendering to a separate package. #595#647ditman wants to merge 4 commits intogoogle:mainfrom
ditman wants to merge 4 commits intogoogle:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
jacobsimionato
approved these changes
Feb 20, 2026
Collaborator
jacobsimionato
left a comment
jacobsimionato
left a comment
There was a problem hiding this comment.
Hey thanks for iterating - this seems a lot lighter! It looks like angular support is gone, but ideally it will be possible to use this same shared interface/package for Angular?
| This is used across all JS renderers, so the configuration is consistent. Each | ||
| renderer has a specific facade package that uses this renderer as a dependency. | ||
|
|
||
| End users should use the facade package for their renderer of choice. |
Collaborator
There was a problem hiding this comment.
Is this still true? It seems like you've managed to reduce it from 3 additional packages to 1, which is excellent!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses some feedback on #595 by dropping some of the "implementation" packages for the markdown renderer, and directly using an injected
renderMarkdownfunction if present. It adds some core types for the generic markdown renderer to be configured and injected.It also updates the lit shell sample app to inject the pre-built renderer, to display how end-users will interact with this.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.