Skip to content

[RFC] Split markdown rendering to a separate package. #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ditman wants to merge 14 commits into
base: main
Choose a base branch
from
+1,521 −448
Draft

[RFC] Split markdown rendering to a separate package. #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a166fcf
Add basic types for the generic markdown renderer.
ditman Feb 20, 2026
07628e0
Remove MarkdownIt from the lit renderer, and instead use an injected …
ditman Feb 20, 2026
35699e6
Add the @a2ui/markdown-it-shared package.
ditman Feb 20, 2026
80c7196
Inject the markdown-it-shared renderer in the lit shell sample.
ditman Feb 20, 2026
f241d39
Export the markdown context from its own file
ditman Feb 20, 2026
3a21fc5
Use the new context name
ditman Feb 20, 2026
45b22f0
Pass the complete MarkdownRendererOptions to the markdown directive f…
ditman Feb 20, 2026
08bce68
Allow injecting a markdownRenderer in the angular renderer.
ditman Feb 20, 2026
db3d4bc
Inject the preconfigured markdown-it-shared in restaurant demo app.
ditman Feb 20, 2026
16f89a4
Make the lit warning flag a static property
ditman Feb 20, 2026
aa1249d
Update markdown-it-shared README
ditman Feb 21, 2026
e9094e5
Push some package-lock.json to make CI happy
ditman Feb 21, 2026
f1010a0
Simplify CI scripts using new targets
ditman Feb 21, 2026
38e0812
Some more package-locks
ditman Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions .github/workflows/lit_samples_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,9 @@ jobs:
with:
node-version: '20'

- name: Install web_core deps
working-directory: ./renderers/web_core
run: npm ci

- name: Build web_core
working-directory: ./renderers/web_core
run: npm run build

- name: Install lib's deps
working-directory: ./renderers/lit
run: npm i

- name: Build lib
working-directory: ./renderers/lit
run: npm run build
- name: Build lit renderer and its dependencies
working-directory: ./samples/client/lit
run: npm run build:renderer

- name: Install all lit samples workspaces' dependencies
working-directory: ./samples/client/lit
Expand Down
28 changes: 4 additions & 24 deletions .github/workflows/ng_build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,34 +35,14 @@ jobs:
with:
node-version: '20'

- name: Install web_core dependencies
working-directory: ./renderers/web_core
run: npm i

- name: Build web_core
working-directory: ./renderers/web_core
run: npm run build

- name: Install web lib deps
working-directory: ./renderers/lit
run: npm i

- name: Build web lib
working-directory: ./renderers/lit
run: npm run build

- name: Install renderer deps
working-directory: ./renderers/angular
run: npm i

- name: Build Angular renderer
working-directory: ./renderers/angular
run: npm run build

- name: Install top-level deps
working-directory: ./samples/client/angular
run: npm i

- name: Build Angular renderer and its dependencies
working-directory: ./samples/client/angular
run: npm run build:renderer

- name: Build contact sample
working-directory: ./samples/client/angular
run: npm run build contact
Expand Down
2 changes: 1 addition & 1 deletion renderers/angular/ng-package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"lib": {
"entryFile": "src/public-api.ts"
},
"allowedNonPeerDependencies": ["markdown-it", "@a2ui/web_core"]
"allowedNonPeerDependencies": ["@a2ui/web_core"]
}
Loading
Loading