Skip to content

Filter out SPE records with irrelevant PIDs#262

Merged
dhoekwater merged 1 commit intogoogle:masterfrom
dhoekwater:fix-spe-pid-filtering
Feb 4, 2026
Merged

Filter out SPE records with irrelevant PIDs#262
dhoekwater merged 1 commit intogoogle:masterfrom
dhoekwater:fix-spe-pid-filtering

Conversation

@dhoekwater
Copy link
Collaborator

975aadd added support for single binary profiles to SPE-based AFDO profile generation, but it broke support for multi-binary profiles by removing PID-based filtering.

Re-add the line that filters out non-mapped PIDs, as even single-binary profiles should include mmap entries for the profiled binary.

@dhoekwater dhoekwater requested a review from snehasish February 3, 2026 22:53
975aadd added support for single
binary profiles to SPE-based AFDO profile generation, but it broke
support for multi-binary profiles by removing PID-based filtering.

Re-add the line that filters out non-mapped PIDs, as even single-
binary profiles should include mmap entries for the profiled binary.
@dhoekwater dhoekwater marked this pull request as draft February 3, 2026 22:56
@dhoekwater dhoekwater force-pushed the fix-spe-pid-filtering branch from 76fcc9c to 22692b9 Compare February 4, 2026 16:34
@dhoekwater dhoekwater marked this pull request as ready for review February 4, 2026 16:36
Copy link
Collaborator

@snehasish snehasish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dhoekwater dhoekwater merged commit 41ff0cc into google:master Feb 4, 2026
3 checks passed
@dhoekwater dhoekwater deleted the fix-spe-pid-filtering branch February 4, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants