-
Notifications
You must be signed in to change notification settings - Fork 37
Suggestions: Update setVisualization util to target the new 12.4 ui as well as the existing ui #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…s well as the existing ui
|
|
1 similar comment
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the setVisualization method in the Panel Editor E2E test utilities to support the new UI introduced in Grafana 12.4, while maintaining backward compatibility with earlier versions. The UI change relocates where the visualization name is displayed in the Panel Editor header.
Key changes:
- Modified the visualization verification logic to check multiple possible selectors using
Promise.allSettled - Added support for the new
PanelEditor.OptionsPane.headerselector (Grafana 12.4+) alongside the existingtoggleVizPickerselector - Changed verification to succeed if at least one selector contains the expected visualization text
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Playwright test results
Troubleshooting404 when clicking on
|
In grafana/grafana#114381, we are updating the UI for the header of the Panel Editor to condense the information a bit.
That means that the final check in this method will no longer work. This change should make it so that the check will succeed for any version of Grafana it's used with.