Skip to content

Conversation

@fastfrwrd
Copy link
Contributor

In grafana/grafana#114381, we are updating the UI for the header of the Panel Editor to condense the information a bit.

Screenshot 2025-11-25 at 4 47 01 PM

That means that the final check in this method will no longer work. This change should make it so that the check will succeed for any version of Grafana it's used with.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@fastfrwrd fastfrwrd changed the title Suggestions: Update setVisualization util to target the new 12.4 ui as well as the existing ui patch: Update setVisualization util to target the new 12.4 ui as well as the existing ui Nov 27, 2025
@fastfrwrd fastfrwrd added patch Increment the patch version when merged release Create a release when this pr is merged labels Nov 27, 2025
@fastfrwrd fastfrwrd changed the title patch: Update setVisualization util to target the new 12.4 ui as well as the existing ui patch(Suggestions): Update setVisualization util to target the new 12.4 ui as well as the existing ui Nov 27, 2025
@fastfrwrd fastfrwrd changed the title patch(Suggestions): Update setVisualization util to target the new 12.4 ui as well as the existing ui Suggestions: Update setVisualization util to target the new 12.4 ui as well as the existing ui Nov 27, 2025
Copilot finished reviewing on behalf of fastfrwrd November 27, 2025 00:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the setVisualization method in the Panel Editor E2E test utilities to support the new UI introduced in Grafana 12.4, while maintaining backward compatibility with earlier versions. The UI change relocates where the visualization name is displayed in the Panel Editor header.

Key changes:

  • Modified the visualization verification logic to check multiple possible selectors using Promise.allSettled
  • Added support for the new PanelEditor.OptionsPane.header selector (Grafana 12.4+) alongside the existing toggleVizPicker selector
  • Changed verification to succeed if at least one selector contains the expected visualization text

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot moved this from 📬 Triage to 🔬 In review in Plugins Platform / Grafana Community Nov 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Playwright test results

Image Name Version Result Report
grafana-dev 12.4.0-19834591820 View report
grafana-enterprise 12.3.0
grafana-enterprise 11.6.8
grafana-enterprise 10.4.19
grafana-enterprise 9.3.16
grafana-enterprise 8.5.27
Troubleshooting

404 when clicking on View report

By default, the deploy-report-pages Action deploys reports to the gh-pages branch. However, you need to take an extra step to ensure that GitHub Pages can build and serve the site from this branch. To do so:

  1. Go to the Settings tab of your repository.
  2. In the left-hand sidebar, click on Pages.
  3. Under Source, select Deploy from a branch, then choose the gh-pages branch.

This action needs to be completed manually in order for your GitHub Pages site to be built and accessible from the gh-pages branch. Once configured, GitHub will automatically build and serve the site whenever new reports are deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged release Create a release when this pr is merged

Projects

Status: 🔬 In review

Development

Successfully merging this pull request may close these issues.

2 participants