grml2usb: replace mbrldr/mbrmgr with syslinux MBR#99
Conversation
|
While looking into the MBR situation for #98, maybe it's time for this also? |
|
I think more code can go away when doing this. Will look more closely later |
zeha
left a comment
There was a problem hiding this comment.
make[1]: Entering directory '/github/workspace'
make -C clean
make[2]: *** clean: No such file or directory. Stop.
make[2]: Entering directory '/github/workspace'
make[1]: *** [Makefile:31: clean] Error 2
make[2]: Leaving directory '/github/workspace'
make[1]: Leaving directory '/github/workspace'
dh_auto_clean: error: make -j4 clean returned exit code 2
make: *** [debian/rules:9: clean] Error 25
dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2
|
📦 Built packages are ready! Download here. |
Uh thanks and sorry, oversight from my side, fixed! |
|
📦 Built packages are ready! Download here. |
|
📦 Built packages are ready! Download here. |
|
this should also go away i think: |
The MirBSD-derived mbrldr/mbrmgr binaries offer no functional advantage over the syslinux MBR. Replace them with automatic syslinux MBR discovery (checking the same paths previously used by --syslinux-mbr), removing the need for a bundled MBR binary. Note that syslinux-common ships the mbr.bin file as /usr/lib/syslinux/mbr/mbr.bin nowadays, so added this path to our mbr_locations where to look for syslinux mbr files. FTR: - Remove mbr directory - Always use syslinux MBR when bootloader is syslinux - Remove ismirbsdmbr logic from install_mbr, always use the standard active partition flag (0x80) - Deprecate --syslinux-mbr and --mbr-menu as no-ops with warnings to preserve backwards compatibility - Drop now no longer needed dependency on nasm - Update Makefile, docs, debian/, tarball.sh + github workflow files accordingly
|
grml2usb.8.adoc also still says this: maybe addtl. doc updates are necessary, please check |
|
📦 Built packages are ready! Download here. |
ACK thanks, I noticed that |
right, lets see about mbr-stuff in this PR though |
|
Please rebase on top of current master. Note that |
I added an efi test in #103. Testing syslinux is for now impossible as the latest daily ISOs no longer contain the required syslinux files. |
The MirBSD-derived mbrldr/mbrmgr binaries offer no functional advantage over the syslinux MBR. Replace them with automatic syslinux MBR discovery (checking the same paths previously used by --syslinux-mbr), removing the need for a bundled MBR binary.
FTR:
NOTE: based on #98