Repository navigation
Keep list navigation stable and preserve terminal failure diagnostics - #44
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is internally consistent and its lifecycle and interactive navigation behavior are covered by focused regression tests.
0 open findings
What changed in this PR
Improves Terminal.Gui navigation stability and ensures lifecycle failures retain complete diagnostics after terminal cleanup.
Changes:
- Keeps list navigation focused and visible at endpoints.
- Adds orderly shutdown, disposal, and exception reporting.
- Adds comprehensive navigation and lifecycle regression tests.
| File | Description |
|---|---|
Program.cs |
Uses centralized application lifecycle handling. |
src/App.cs |
Stabilizes navigation, scrolling, cancellation, and disposal. |
src/ApplicationLifetime.cs |
Coordinates startup, shutdown, cleanup, and diagnostics. |
src/BackgroundTaskTracker.cs |
Exposes failure recording for cancellation errors. |
src/PackageListView.cs |
Prevents endpoint navigation from escaping lists. |
src/Ui.cs |
Supports empty version lists safely. |
src/WorkflowDialogs.cs |
Applies stable navigation to dialog lists. |
tests/ApplicationLifetimeTests.cs |
Tests independent cleanup and diagnostic preservation. |
tests/ListNavigationTests.cs |
Tests navigation, filtering, refresh races, and callbacks. |
docs/architecture.md |
Documents lifecycle ownership and cleanup behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
harder
force-pushed
the
codex/list-navigation-safety
branch
from
October 14, 2026 00:36
2935b0d to
5823fa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated navigation past list endpoints lets Terminal.Gui keys reach parent focus handlers; dialog lists can move focus to action buttons. Scout's
j/kand filter-input cursor changes also selected rows without scrolling them into view, and Home/End used column movement despite the row-navigation help.This keeps endpoint navigation in package tables and related dialog lists while preserving Tab, scrolls programmatic cursor moves, maps Home/End to table start/end, and permits an empty version picker. Direct window disposal now stops UI callback admission before child disposal. Cancellation callback failures are retained, and startup/run/shutdown/disposal exceptions keep their stack traces and inner exceptions, printed after independent terminal cleanup attempts.
Validation:
2.5.1-develop.44against its recorded upstream source commit. NoAGENTS.mdexists in this checkout or its parent directories; followed CONTRIBUTING and CI gates.Widening source/local filters and late inventory/detail responses passed without additional production fixes. The reported macOS crash and leaked mouse escape codes were not reproduced; macOS/Linux interactive validation was not run.