Skip to content

Conversation

@tgross
Copy link
Member

@tgross tgross commented Nov 7, 2025

When using the Go API to read from the event stream, the API documentation says the topic filter is optional. But if omitted, we end up not sending any topic parameter. Making an event stream query without a topic or with a * wildcard topic filter is only allowed by the management token.

If the developer provides a topic without a filter, treat this as a bare topic request as one would expect.

Fixes: #27063

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

When using the Go API to read from the event stream, the API documentation says
the topic filter is optional. But if omitted, we end up not sending any topic
parameter. Making an event stream query without a topic or with a `*` wildcard
topic filter is only allowed by the management token.

If the developer provides a topic without a filter, treat this as a bare topic
request as one would expect.

Fixes: #27063
@tgross tgross force-pushed the api-event-acl-wildcard branch from c441cef to 990d0a8 Compare November 7, 2025 21:16
@tgross tgross added theme/api HTTP API and SDK issues type/bug backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.10.x+ent backport to 1.10.x+ent release line labels Nov 7, 2025
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross added backport/ent/1.11.x+ent backport/1.11.x backport to 1.11.x release line and removed backport/ent/1.11.x+ent labels Nov 11, 2025
@tgross tgross merged commit bc4f1cb into main Nov 12, 2025
55 checks passed
@tgross tgross deleted the api-event-acl-wildcard branch November 12, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.10.x+ent backport to 1.10.x+ent release line backport/1.11.x backport to 1.11.x release line theme/api HTTP API and SDK issues type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subscribing to an event topic without a filter using the Go SDK can fail

2 participants