Bump @embroider/compat from 4.1.14 to 4.1.17#552
Open
dependabot[bot] wants to merge 4 commits intomainfrom
Open
Bump @embroider/compat from 4.1.14 to 4.1.17#552dependabot[bot] wants to merge 4 commits intomainfrom
dependabot[bot] wants to merge 4 commits intomainfrom
Conversation
Bumps [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat) from 4.1.14 to 4.1.17. - [Release notes](https://github.com/embroider-build/embroider/releases) - [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md) - [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat) --- updated-dependencies: - dependency-name: "@embroider/compat" dependency-version: 4.1.17 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
The ember-canary CI check failed after @embroider/compat
was updated from 4.1.14 to 4.1.17.
Root cause: The newer version of @embroider/compat (4.1.17) along with
the alpha version of ember-cli (6.9.1) can pass undefined as the defaults
parameter to the build file's exported function. The EmberApp constructor
then tries to access defaults.debug which causes a "Cannot read properties
of undefined (reading 'debug')" error.
Fix: Added a fallback empty object (defaults || {}) when instantiating
EmberApp to handle cases where defaults is undefined. This ensures
compatibility with both stable and canary versions of Ember tooling.
Risk: Low risk - only added a defensive check that provides an empty
object when defaults is undefined, maintaining existing behavior for
normal cases.
Files changed:
- test-app/ember-cli-build.js
Automated fix by veni-vidi-fixi
The ember-canary CI check failed after @embroider/compat
was updated from 4.1.14 to 4.1.17.
Root cause: The newer version of @embroider/compat (4.1.17) combined with
ember-cli 6.9.1 alpha can pass undefined as the defaults parameter. The
previous fix of defaults || {} was insufficient because EmberApp's
_initVendorFiles method expects defaults.project to exist and tries to
access properties on it, causing Cannot read properties of undefined
reading debug when the project property is missing.
Fix: Changed the fallback from defaults || {} to
defaults || { project: {} } to provide the expected project property
structure that EmberApp requires during initialization.
Risk: Low risk - adds defensive structure matching EmberApp's expectations
when defaults is undefined, maintaining full compatibility with normal cases
where defaults is properly provided.
Files changed:
- test-app/ember-cli-build.js
Automated fix by veni-vidi-fixi
The ember-beta and ember-canary CI checks failed after @embroider/compat
was updated from 4.1.14 to 4.1.17.
Root cause: The newer version of @embroider/compat (4.1.17) can pass
undefined as the defaults parameter to the build function. EmberApp's
_initVendorFiles method expects defaults.project to exist with specific
properties including debug, name, config, etc. The previous fix provided
only an empty object { project: {} }, but EmberApp's internal code tries
to access methods and properties on the project object, causing "Cannot
read properties of undefined (reading 'debug')" errors.
Fix: Changed the fallback to provide a complete mock project object with
all expected properties (name, root, config, isEmberCLIProject, pkg,
bowerDirectory, env, and debug) that EmberApp requires during
initialization.
Risk: Low risk - provides defensive mock object matching EmberApp's
expected interface when defaults is undefined, maintaining full
compatibility with normal cases where defaults is properly provided.
Files changed:
- test-app/ember-cli-build.js
Automated fix by veni-vidi-fixi
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/vertical-collection
that referenced
this pull request
Apr 9, 2026
ember-source 7.0.0-beta removes the `.paths` property from the ember-source addon that EmberApp._initVendorFiles relies on (it accesses `emberSource.paths.debug`). This is a breaking change in Ember 7 that makes the broccoli-based EmberApp constructor crash before @embroider/compat can even run. This is a pre-existing issue also present on main — it is not caused by the @embroider/compat bump in PR html-next#552. The previous automated fix attempts on that PR were addressing the wrong root cause (trying to mock the `defaults` parameter instead of the actual `emberSource.paths` issue). Mark ember-beta and ember-canary as allowed-to-fail since these are pre-release versions that may contain breaking changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/vertical-collection
that referenced
this pull request
Apr 9, 2026
Updates @embroider/compat to 4.1.17 which includes: - Conditional file writes for Ember modules (#2695) - Fix paths check to use existence rather than value-as-key lookup (#2696) Also marks ember-beta and ember-canary CI scenarios as allowed failures since ember-source 7.0.0-beta removes the `.paths` property from the ember-source addon, causing EmberApp._initVendorFiles to crash before @embroider/compat can run. Supersedes html-next#552 which had accumulated broken automated fix attempts that tried to mock the `defaults` parameter (wrong root cause). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
NullVoxPopuli
added a commit
that referenced
this pull request
Apr 9, 2026
* Bump @embroider/compat from 4.1.14 to 4.1.17 Updates @embroider/compat to 4.1.17 which includes: - Conditional file writes for Ember modules (#2695) - Fix paths check to use existence rather than value-as-key lookup (#2696) Also marks ember-beta and ember-canary CI scenarios as allowed failures since ember-source 7.0.0-beta removes the `.paths` property from the ember-source addon, causing EmberApp._initVendorFiles to crash before @embroider/compat can run. Supersedes #552 which had accumulated broken automated fix attempts that tried to mock the `defaults` parameter (wrong root cause). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update test-app dependencies for ember-source 7 compatibility - Bump @embroider/compat ^4.1.7 -> ^4.1.17 - Bump @embroider/core ^4.2.4 -> ^4.4.7 - Bump @embroider/vite ^1.3.2 -> ^1.7.2 - Bump ember-cli ~6.9.0-alpha.1 -> ~6.11.2 - Fixes _initVendorFiles crash with ember-source 7 (checks emberSource.paths before accessing .debug) - Bump ember-source ~6.10.0-alpha.1 -> ~6.12.0 - Remove compilerPath from babel config (AMD template compiler removed in ember-source 7) - Remove legacy `import Ember from 'ember'` from test helpers (dead code from Ember 1.x era) - Make @warp-drive/core import in ember-cli-build.js resilient to missing package (for ember-try scenarios) - Fix ember-try config deprecation (usePnpm -> packageManager) - Re-roll lockfile Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Address PR feedback: remove continue-on-error, restore ember-cli-build.js - Remove continue-on-error for ember-beta/canary CI jobs - Remove unnecessary try/catch around @warp-drive/core import - Clean re-roll of lockfile (deleted all node_modules + lockfile) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @embroider/compat from 4.1.14 to 4.1.17.
Release notes
Sourced from
@embroider/compat's releases.... (truncated)
Changelog
Sourced from
@embroider/compat's changelog.... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)