Conversation
dmke
force-pushed
the
reduce-dependencies
branch
from
April 30, 2026 22:34
501fbd1 to
db20b30
Compare
dmke
force-pushed
the
reduce-dependencies
branch
4 times, most recently
from
April 30, 2026 23:35
365b031 to
6a57496
Compare
This is an effort to reduce the number of gems consumers need to install in their application. Since `omniauth-keycloak` depends on `omniauth-oauth2`, and the latter includes the `jwt` gem, we don't need to depend on `json-jwt`.
Extracts fetching of configuration and certificates into seperate methods.
dmke
force-pushed
the
reduce-dependencies
branch
from
August 3, 2026 16:28
10ea2f9 to
79168ac
Compare
Using `OmniAuth.config.test_mode` masks a lot of code that is otherwise not tested. This adds a full-stack integration spec (using Rack::Test as mock Keycloak server).
dmke
force-pushed
the
reduce-dependencies
branch
from
August 3, 2026 16:32
79168ac to
e176680
Compare
Author
|
Pinging @tagliala for review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an effort to reduce the number of gems consumers need to install in their application. Since
omniauth-keycloakdepends onomniauth-oauth2, and the latter includes thejwtgem, we don't need to depend onjson-jwt.This also includes integration specs to make sure the JWT is properly decoded.
I have added a few additional commits, feel free to pick and choose:
#setup_phaseand moves fetching of OIDC config and JWKS certificates into their own methodsrubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestampGHA: Bump actions/checkout to v6 amends Improve CI #24 :)(Dropped after rebased onto master).