Skip to content

build(pip): require java-api 17.26.5+#30

Merged
cesarcoatl merged 2 commits into8.3from
8.3-build/pip/java-api-17.26.5
Apr 30, 2026
Merged

build(pip): require java-api 17.26.5+#30
cesarcoatl merged 2 commits into8.3from
8.3-build/pip/java-api-17.26.5

Conversation

@cesarcoatl
Copy link
Copy Markdown
Member

@cesarcoatl cesarcoatl commented Apr 30, 2026

this version introduced java.lang.Record
8.3.5.post1 and beyond will require this

Summary by Sourcery

Build:

  • Update setup.cfg to depend on java-api version 17.26.5 or newer.

this version introduced java.lang.Record
8.3.5.post1 and beyond will require this
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Apr 30, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Python packaging metadata to require at least version 17.26.5 of the java-api dependency, aligning with the need for java.lang.Record support for versions 8.3.5.post1 and later.

File-Level Changes

Change Details Files
Tighten java-api dependency requirement in packaging configuration to ensure availability of java.lang.Record for newer releases.
  • Change install_requires entry from an unpinned java-api to a minimum version constraint java-api>=17.26.5 in setup.cfg
  • Keep all other packaging settings (Python version, packages, project URLs, etc.) unchanged
setup.cfg

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • You updated the java-api constraint in setup.cfg but not in requirements.in; consider aligning the version requirement there as well to keep dependency definitions consistent.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- You updated the `java-api` constraint in `setup.cfg` but not in `requirements.in`; consider aligning the version requirement there as well to keep dependency definitions consistent.

## Individual Comments

### Comment 1
<location path="setup.cfg" line_range="41" />
<code_context>
 enum34
-java-api
+java-api>=17.26.5
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Consider constraining the upper bound of `java-api` or documenting compatibility assumptions.

Using `java-api>=17.26.5` without an upper bound means any future breaking major version will be pulled in, which is risky for a Python 2.7–locked project that may not be updated often. Please either add a conservative upper cap (e.g., `<18`) based on what’s validated, or document a confirmed semver guarantee that future major versions will remain compatible.

```suggestion
    # Pin java-api to a compatible major version range for this Python 2.7.18 project.
    # Future major versions may introduce breaking changes; adjust the upper bound after validation.
    java-api>=17.26.5,<18
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread setup.cfg
install_requires =
enum34
java-api
java-api>=17.26.5
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Consider constraining the upper bound of java-api or documenting compatibility assumptions.

Using java-api>=17.26.5 without an upper bound means any future breaking major version will be pulled in, which is risky for a Python 2.7–locked project that may not be updated often. Please either add a conservative upper cap (e.g., <18) based on what’s validated, or document a confirmed semver guarantee that future major versions will remain compatible.

Suggested change
java-api>=17.26.5
# Pin java-api to a compatible major version range for this Python 2.7.18 project.
# Future major versions may introduce breaking changes; adjust the upper bound after validation.
java-api>=17.26.5,<18

@cesarcoatl cesarcoatl merged commit 2767d17 into 8.3 Apr 30, 2026
5 checks passed
@cesarcoatl cesarcoatl deleted the 8.3-build/pip/java-api-17.26.5 branch April 30, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant