Skip to content

build(pip): require java-api 17.26.5+ #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cesarcoatl merged 2 commits into from
Apr 30, 2026
Merged

build(pip): require java-api 17.26.5+ #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98928be
build(pip): require java-api 17.26.5+
cesarcoatl Apr 30, 2026
aaa1003
build(pip): update stubs requirements
cesarcoatl Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
enum34
java-api
java-api>=17.26.5
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ project_urls =
packages = find:
install_requires =
enum34
java-api
java-api>=17.26.5
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Consider constraining the upper bound of java-api or documenting compatibility assumptions.

Using java-api>=17.26.5 without an upper bound means any future breaking major version will be pulled in, which is risky for a Python 2.7–locked project that may not be updated often. Please either add a conservative upper cap (e.g., <18) based on what’s validated, or document a confirmed semver guarantee that future major versions will remain compatible.

Suggested change
java-api>=17.26.5
# Pin java-api to a compatible major version range for this Python 2.7.18 project.
# Future major versions may introduce breaking changes; adjust the upper bound after validation.
java-api>=17.26.5,<18

python_requires = ==2.7.18
package_dir =
=src
Expand Down
2 changes: 1 addition & 1 deletion stubs/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ classifiers = [
"Typing :: Typed",
]
dependencies = [
"java-api-stubs",
"java-api-stubs>=17.26.5",
"types-enum34",
]
urls.Documentation = "https://docs.inductiveautomation.com/docs/8.3/appendix/scripting-functions"
Expand Down