Skip to content

Began testing ember-lts-6.12, ember-beta, and ember-canary scenarios#247

Merged
ijlee2 merged 4 commits into
mainfrom
update-try-scenarios
May 6, 2026
Merged

Began testing ember-lts-6.12, ember-beta, and ember-canary scenarios#247
ijlee2 merged 4 commits into
mainfrom
update-try-scenarios

Conversation

@ijlee2
Copy link
Copy Markdown
Owner

@ijlee2 ijlee2 commented May 6, 2026

Why?

Follows up on #216 and #238.

What changed?

  • Replaced ember-lts-6.8 with ember-lts-6.12.
  • Enabled ember-beta and ember-canary to show compatibility with ember-source@7.0.0.

@ijlee2 ijlee2 added the enhance: documentation Issue asks for better documentation (e.g. README, code, tests) label May 6, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2026

Deploy Preview for embroider-css-modules ready!

Name Link
🔨 Latest commit a1ddf6c
🔍 Latest deploy log https://app.netlify.com/projects/embroider-css-modules/deploys/69fb3c92c65f7a0007f9110d
😎 Deploy Preview https://deploy-preview-247--embroider-css-modules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ijlee2 ijlee2 force-pushed the update-try-scenarios branch from a3706bc to a1ddf6c Compare May 6, 2026 13:05
"lint:types": "ember-tsc --noEmit",
"start": "vite",
"test": "vite build --mode test && ember test --config-file \"./testem.cjs\" --path dist --test-port 0"
"test": "NODE_ENV=development vite build --mode development && ember test --config-file \"./testem.cjs\" --path dist --test-port 0"
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related:

It's important to note that NODE_ENV (process.env.NODE_ENV) and modes are two different concepts. Here's how different commands affect the NODE_ENV and mode:

Command NODE_ENV Mode
vite build "production" "production"
vite build --mode development "production" "development"
NODE_ENV=development vite build "development" "production"
NODE_ENV=development vite build --mode development "development" "development"

https://vite.dev/guide/env-and-mode#node-env-and-modes

@ijlee2 ijlee2 marked this pull request as ready for review May 6, 2026 13:09
@ijlee2 ijlee2 merged commit 7f1b793 into main May 6, 2026
31 checks passed
@ijlee2 ijlee2 deleted the update-try-scenarios branch May 6, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhance: documentation Issue asks for better documentation (e.g. README, code, tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant