Began testing ember-lts-6.12, ember-beta, and ember-canary scenarios#247
Merged
Conversation
✅ Deploy Preview for embroider-css-modules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4facb00 to
a3706bc
Compare
a3706bc to
a1ddf6c
Compare
ijlee2
commented
May 6, 2026
| "lint:types": "ember-tsc --noEmit", | ||
| "start": "vite", | ||
| "test": "vite build --mode test && ember test --config-file \"./testem.cjs\" --path dist --test-port 0" | ||
| "test": "NODE_ENV=development vite build --mode development && ember test --config-file \"./testem.cjs\" --path dist --test-port 0" |
Owner
Author
There was a problem hiding this comment.
Related:
- Test for an addon failed in ember-source@7.0.0-beta.1 and ember-source@7.1.0-alpha.4 emberjs/ember.js#21374
- Fix CI for ember-source 7 embroider-build/embroider#2719
It's important to note that
NODE_ENV(process.env.NODE_ENV) and modes are two different concepts. Here's how different commands affect theNODE_ENVand mode:
Command NODE_ENV Mode vite build"production""production"vite build --mode development"production""development"NODE_ENV=development vite build"development""production"NODE_ENV=development vite build --mode development"development""development"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Follows up on #216 and #238.
What changed?
ember-lts-6.8withember-lts-6.12.ember-betaandember-canaryto show compatibility withember-source@7.0.0.