Conversation
The StarkExchangeMigrationV2 implementation is now deployed on mainnet at 0x273b65a7231321D4ee47a4c47408Ef43517455Ec. Update the integration tests to reference the deployed address rather than deploying a fresh instance, and add a bytecode equivalence check against the locally compiled contract. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ermyas
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StarkExchangeMigrationV2implementation (0x273b65a7231321D4ee47a4c47408Ef43517455Ec) in the integration test instead of deploying a fresh instance.FORK_BLOCKto24920000(past the deployment block 24918805).test_DeployedBytecodeMatchesCompiledto assert the on-chain runtime bytecode matches a locally compiled instance.Test plan
ETH_RPC_URL=… forge test --match-path test/integration/bridge/starkex/StarkExchangeMigrationV2.t.sol -vv— all 9 tests pass, including the new bytecode check.🤖 Generated with Claude Code
Note
Low Risk
Low risk: test-only changes that adjust fork block/upgrade target and add a bytecode equivalence assertion; no production contract logic is modified.
Overview
Integration tests now upgrade the StarkEx proxy to the mainnet-deployed
StarkExchangeMigrationV2implementation (DEPLOYED_IMPL) instead of deploying a fresh one, and the fork block is bumped to a height where that implementation exists.Adds
test_DeployedBytecodeMatchesCompiledto assert the deployed runtime bytecode equals a locally compiledStarkExchangeMigrationV2, helping ensure the test is exercising the exact on-chain code.Reviewed by Cursor Bugbot for commit 090aa1a. Bugbot is set up for automated code reviews on this repo. Configure here.