Skip to content

Use deployed StarkExchangeMigrationV2 impl in integration tests #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lfportal merged 1 commit into from
Apr 21, 2026
Merged

Use deployed StarkExchangeMigrationV2 impl in integration tests #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions test/integration/bridge/starkex/StarkExchangeMigrationV2.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,12 @@ contract StarkExchangeMigrationV2IntegrationTest is Test {
address private constant STARKEX_PROXY_OWNER = 0xD2C37fC6fD89563187f3679304975655e448D192;
address private constant VCO_TOKEN = 0x2Caa4021e580b07D92adf8A40Ec53b33a215D620;

/// @dev Deployed StarkExchangeMigrationV2 implementation on mainnet
address private constant DEPLOYED_IMPL = 0x273b65a7231321D4ee47a4c47408Ef43517455Ec;

/// @dev Mainnet block at which the StarkEx bridge holds VCO tokens pre-migration
uint256 private constant FORK_BLOCK = 24890212;
/// and the StarkExchangeMigrationV2 implementation is deployed
uint256 private constant FORK_BLOCK = 24920000;

function setUp() public {
string memory RPC_URL = vm.envString("ETH_RPC_URL");
Expand All @@ -53,15 +57,23 @@ contract StarkExchangeMigrationV2IntegrationTest is Test {
function _upgradeTo() internal returns (address) {
vm.startPrank(STARKEX_PROXY_OWNER);

address newImpl = address(new StarkExchangeMigrationV2());
bytes memory initData = bytes("");

starkExProxy.addImplementation(newImpl, initData, false);
starkExProxy.addImplementation(DEPLOYED_IMPL, initData, false);
skip(15 days);
starkExProxy.upgradeTo(newImpl, initData, false);
starkExProxy.upgradeTo(DEPLOYED_IMPL, initData, false);

vm.stopPrank();
return newImpl;
return DEPLOYED_IMPL;
}

function test_DeployedBytecodeMatchesCompiled() public {
address freshImpl = address(new StarkExchangeMigrationV2());
assertEq(
DEPLOYED_IMPL.code,
freshImpl.code,
"Deployed implementation bytecode should match locally compiled bytecode"
);
}

function test_Upgrade_ImplementationUpdated() public {
Expand Down
Loading