Repository navigation
chore: Use tf plugin docs - #3380
Merged
Merged
Conversation
stevehipwell
added
Type: Documentation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
stevehipwell
force-pushed
the
plugin-docs-migrate
branch
from
April 29, 2026 14:56
7288bbb to
7ff5ce8
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
plugin-docs-migrate
branch
from
April 29, 2026 15:03
7ff5ce8 to
497864c
Compare
deiga
requested changes
May 1, 2026
Collaborator
Author
|
@deiga could you please re-review. |
Collaborator
Author
|
@robert-crandall please could you review/approve this PR? |
robert-crandall
approved these changes
May 5, 2026
1 task done
allandegnan
added a commit
to alphagov/terraform-provider-github
that referenced
this pull request
May 21, 2026
Templates added in PR integrations#3380 (tfplugindocs migration) — generate docs/resources/*.md from templates/resources/*.md.tmpl. The previously hand-written docs file is replaced with the regenerated output. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 of 7 tasks
2 of 3 tasks
2 of 5 tasks
austenstone
pushed a commit
to austenstone/terraform-provider-github
that referenced
this pull request
Jun 9, 2026
* chore: Use tf plugin docs Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com> * fixup! chore: Use tf plugin docs * fixup! chore: Use tf plugin docs --------- Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
austenstone
pushed a commit
to austenstone/terraform-provider-github
that referenced
this pull request
Jun 9, 2026
* chore: Use tf plugin docs Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com> * fixup! chore: Use tf plugin docs * fixup! chore: Use tf plugin docs --------- Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
sprioriello
pushed a commit
to sprioriello/terraform-provider-github
that referenced
this pull request
Jun 10, 2026
…ns#3380) - remove website/docs/r pages (no longer published since integrations#3380) - add examples/resources/ + templates/resources/ for both resources - commit generated docs/resources pages from make generatedocs
corymhall
pushed a commit
to pulumi/pulumi-github
that referenced
this pull request
Aug 14, 2026
Unblocks the nightly `upgrade-provider` job and pulls in upstream v6.13.0. ## Why this was stuck Upstream v6.13.0 refactored the provider entry point in [#3440](integrations/terraform-provider-github#3440), replacing the parameterless `github.Provider()` with `github.NewProvider(version, commit)`, which returns the provider factory. The nightly [Upgrade provider](https://github.com/pulumi/pulumi-github/actions/workflows/upgrade-provider.yml) job rebases onto the new tag fine, then dies in codegen: ``` ./scripts/upstream.sh rebase -o refs/tags/v6.13.0: done error: upgrade-provider executed `make tfgen` which failed: exit status 2: ./resources.go:78:33: undefined: github.Provider make: *** [Makefile:323: bin/pulumi-tfgen-github] Error 1 ``` It has failed every night since v6.13.0 was released on 2026-07-08, so the bridge is still pinned to upstream v6.12.1 and none of the fixes below have shipped. ## Changes - `provider/resources.go`: use `github.NewProvider(version.Version, "")()`. `version` and `commit` only feed the upstream User-Agent and debug logging; the bridge appends its own Pulumi User-Agent, so the commit is left empty. This is the only hand-written change. - `upstream`: v6.12.1 → v6.13.0 (via `upstream.sh checkout` / `rebase -o refs/tags/v6.13.0` / `check_in`). - Regenerated schema, all five SDKs, and `docs/_index.md`. ## Notable upstream fixes pulled in - **`github_team_repository` delete now treats a 404 from GitHub as a successful delete** ([#3524](integrations/terraform-provider-github#3524)). Previously the 404 branch only recovered from repository *renames*: it re-read the repo and retried the delete only when `.GetName()` differed. A repository transferred to a **different organization** keeps its name, so the retry was skipped and the original 404 surfaced as a hard error. Any stack still holding that resource in state is then permanently wedged — every subsequent update fails on the same undeletable resource, and the only escape is `pulumi state delete`. - Fixes a nil-pointer panic in that same delete path when the API call fails at the transport layer ([#3518](integrations/terraform-provider-github#3518)). - `github_team_members` deletion is skipped when the parent team is already gone ([#3461](integrations/terraform-provider-github#3461)). ## Schema impact Additive — nothing removed or retyped (verified by diffing schema keys against `master`): - New provider config options: `cachePath`, `legacyClient` - New resource properties: `BranchDefault.repositoryId`, `BranchDefault.waitForRename`, `RepositoryCollaborators.ownerConfigured`, `RepositoryCustomProperty.repositoryId`, `TeamMembers.teamSlug` The bulk of the schema and `docs/_index.md` diff is upstream's migration to tfplugindocs ([#3380](integrations/terraform-provider-github#3380)) and its rewritten provider docs and examples ([#3440](integrations/terraform-provider-github#3440)) — restyled descriptions, and the overview example changing from `github_membership` to `getRepository` because upstream replaced `examples/provider/example_1.tf`/`example_2.tf` with a single `provider.tf`. ## Verification - `make tfgen` succeeds; example conversion 93.39% (1314/1407) - All five SDKs generated; Go SDK compiles - `dotnet build` not run locally (unrelated local NuGet source misconfiguration) — leaving that to CI - Acceptance tests not run locally 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2924
Resolves #2961
Resolves #2897
Resolves #3241
Closes #2987
Closes #3199
Before the change?
After the change?
tfplugindocsPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!