Skip to content

Fix non-passive event listeners issue and add a updated version number#215

Closed
summercms wants to merge 0 commit into
jquery:mainfrom
summercms:passive
Closed

Fix non-passive event listeners issue and add a updated version number#215
summercms wants to merge 0 commit into
jquery:mainfrom
summercms:passive

Conversation

@summercms

Copy link
Copy Markdown

Relates to (my old account) issue found here: #202

Have tested this and works fine.

@ghost

ghost commented Sep 27, 2021

Copy link
Copy Markdown

@mgol another one to review after #127

@ghost ghost mentioned this pull request Sep 27, 2021

@mgol mgol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is essentially a noop but it doesn't work in IE which has no support for passive listeners. The upstream jQuery also doesn't use a pattern like this so I'm not in favor.

@dmethvin what do you think?

@ghost

ghost commented Sep 27, 2021

Copy link
Copy Markdown

Could it be put behind a compatibility layer for non-IE?

@mgol

mgol commented Sep 27, 2021

Copy link
Copy Markdown
Member

Yes, it could, but it'd still be adding lots of bytes just to silence browser warnings without any actual change in behavior. If we were doing that for jQuery as well it'd make sense but I'm not sure about doing it just in this plugin, diverging from the upstream.

@ghost

ghost commented Sep 27, 2021

Copy link
Copy Markdown

Okay, so the ideal thing to do is icebox this and have passive event listeners adopted in JQ core?

@mgol

mgol commented Sep 27, 2021 via email

Copy link
Copy Markdown
Member

@summercms

summercms commented Apr 20, 2022

Copy link
Copy Markdown
Author

@mgol Internet Explorer 11 desktop application will be retired and go out of support on June 15, 2022. Therefore this repo shouldn't continue to support ie11 after end of life date reached.

Link: https://blogs.windows.com/windowsexperience/2021/05/19/the-future-of-internet-explorer-on-windows-10-is-in-microsoft-edge/

@mgol

mgol commented Apr 20, 2022

Copy link
Copy Markdown
Member

This project will most likely keep following the browser support policy of jQuery and there are no plans to drop IE 11 support there yet.

@nagyimre1980

Copy link
Copy Markdown

next release should include this

@mgol

mgol commented Mar 17, 2025

Copy link
Copy Markdown
Member

This will not be included in the next release as it depends on changes in jQuery which are currently scheduled for 5.0.0.

@summercms

summercms commented Jul 14, 2025

Copy link
Copy Markdown
Author

Closed this PR, very old and opened a new one here: #254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants