Skip to content

Fix corrupt analog data for non-float values - #64

Closed
taligentx wants to merge 2 commits into
knarfS:masterfrom
taligentx:master
Closed

taligentx wants to merge 2 commits into
knarfS:masterfrom
taligentx:master

Conversation

@taligentx

Copy link
Copy Markdown
Contributor

Hi,

This fixes an issue that causes invalid data in SmuView for non-float analog data. I ran into this when writing a driver for serial-dmm where the value is stored as a double. feed_in_analog() is getting the original value converted to float, but then push_interleaved_samples() is sending the original unit size (8 for double) instead of the float size and results in corrupt data.

Let me know if there are any issues or if there's another way to tackle this - thanks!

-Nikhil

@knarfS

knarfS commented Sep 2, 2026

Copy link
Copy Markdown
Owner

It took some time, but I was finally able to merge your commits:

  • "Fix analog data handling for non-float values" with commit 114a934
  • "Fix segfault when adding signal to data table with no signals loaded" was merged with commit 744a561

I changed the commit messages slightly.

Thank you for contributing

@knarfS knarfS closed this Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants