Conversation
Owner
|
It took some time, but I was finally able to merge your commits:
I changed the commit messages slightly. Thank you for contributing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This fixes an issue that causes invalid data in SmuView for non-float analog data. I ran into this when writing a driver for serial-dmm where the value is stored as a double.
feed_in_analog()is getting the original value converted to float, but thenpush_interleaved_samples()is sending the original unit size (8 for double) instead of the float size and results in corrupt data.Let me know if there are any issues or if there's another way to tackle this - thanks!
-Nikhil