Conversation
kubevirt-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
aburdenthehand
left a comment
aburdenthehand
left a comment
There was a problem hiding this comment.
/lgtm
Nice work @xpivarc
I have suggested a couple of nits.
| ## Preparation of PCI devices for passthrough | ||
|
|
||
| At this time, KubeVirt is only able to assign PCI devices that are using the `vfio-pci` driver. To prepare a specific device for device assignment, it should first be unbound from its original driver and bound to the `vfio-pci` driver. | ||
| At this time, KubeVirt is only able to assign PCI devices that are using the `vfio-pci` driver (except for [SR-IOV vGPU](#preparation-of-vgpu-devices-with-sr-iov)). To prepare a specific device for device assignment, it should first be unbound from its original driver and bound to the `vfio-pci` driver. |
There was a problem hiding this comment.
| At this time, KubeVirt is only able to assign PCI devices that are using the `vfio-pci` driver (except for [SR-IOV vGPU](#preparation-of-vgpu-devices-with-sr-iov)). To prepare a specific device for device assignment, it should first be unbound from its original driver and bound to the `vfio-pci` driver. | |
| At this time, KubeVirt is only able to assign PCI devices that are using the `vfio-pci` driver, with the exception of [SR-IOV vGPU](#preparation-of-vgpu-devices-with-sr-iov). To prepare a specific device for device assignment, it should first be unbound from its original driver and bound to the `vfio-pci` driver. |
| ## Preparation of vGPU devices with SR-IOV | ||
|
|
||
| In general, configuration of vGPUs with SR-IOV should be done according to the vendor directions. | ||
| KubeVirt doesn't support creation of virtual function (VF) nor the assignment of vGPU profile to the function. |
There was a problem hiding this comment.
| KubeVirt doesn't support creation of virtual function (VF) nor the assignment of vGPU profile to the function. | |
| KubeVirt does not support the creation of virtual function (VF) nor the assignment of vGPU profile to the function. |
|
|
||
| In general, configuration of vGPUs with SR-IOV should be done according to the vendor directions. | ||
| KubeVirt doesn't support creation of virtual function (VF) nor the assignment of vGPU profile to the function. | ||
| KubeVirt only facilitates exposure of these virtual functions for the VM to consume them (through generic PCI device plugin) but doesn't have fine-grained distinctions of the profiles such as for the mdevs. Therefore it is recommended to use vendor's device plugin to expose the functions in case of heterogeneous profiles. |
There was a problem hiding this comment.
| KubeVirt only facilitates exposure of these virtual functions for the VM to consume them (through generic PCI device plugin) but doesn't have fine-grained distinctions of the profiles such as for the mdevs. Therefore it is recommended to use vendor's device plugin to expose the functions in case of heterogeneous profiles. | |
| KubeVirt only facilitates exposure of these VFs for the VM to consume them (through generic PCI device plugin) but does not have fine-grained distinctions of the profiles, like those for mdevs. Therefore it is recommended to use vendor's device plugin to expose the functions in case of heterogeneous profiles. |
?
|
Pull requests that are marked with After that period the bot marks them with the label /label needs-approver-review |
kubevirt-prow
Bot
added
the
needs-approver-review
Document the limitations and usage of SR-IOV-based vGPU passthrough, including the distinction from mediated devices and when to use what device plugin. Signed-off-by: Luboslav Pivarc <lpivarc@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This branch has not been deployed
3 participants
What this PR does / why we need it:
Document the limitations and usage of SR-IOV-based vGPU passthrough, including the distinction from mediated devices and when to use what device plugin.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: