fix: correct fabricated and top-level-misattributed SDK calls in sdk-overview.md - #80
fix: correct fabricated and top-level-misattributed SDK calls in sdk-overview.md#809Olive wants to merge 3 commits into
Conversation
|
Hold / scope down: the module-path moves are actually correct against installed kumoai 2.22.0 ( Automated internal-consistency review (cross-checked against the repo's own authoritative docs; a few SDK-surface claims spot-checked against installed kumoai 2.22.0). |
|
Hold for maintainer review (relates to the closed #84). Verified against source, most of this PR is correct:
One regression to fix before merge: the PR deletes the valid |
Changes needed before mergeRequired changesAccuracy fix: Restore the valid inherited # /home/leena/code/kumo/kumo-sdk/kumoai/jobs.py:57
def get_tags(self) -> dict[str, str]:
# /home/leena/code/kumo/kumo-sdk/kumoai/trainer/job.py:555
class TrainingJob(JobInterface[...], KumoProgressFuture[...]):Accuracy fix: Replace the unsupported placeholder training_df = training_table.data_df()
training_df.head(n=10)
len(training_df)
training_df.describe()
training_df["TARGET"].value_counts()Evidence: # /home/leena/code/kumo/kumo-sdk/examples/datasets/weighted_train_table.py:101-103
df = train_table.data_df()
df['weight'] = 1
df.loc[df['TARGET'] > df['TARGET'].mean(), 'weight'] = 2Accurate checksThe other API corrections are supported by
These findings are consistent across SDK v2.16.3 and v2.22.0. Optional follow-upOptional completeness: Local checksNo direct credential-free end-to-end SDK test was available. Grammar/spelling: No blocking grammar or spelling issues found. |
…ning-table-api # Conflicts: # context/platform/sdk-overview.md
|
Thanks @leena-kang and @Manushpm8 — both accuracy fixes applied, and I resolved the merge conflict with
The confirmed API corrections ( While resolving the conflict I also caught that Separately, your optional follow-up ( |
context/platform/sdk-overview.md (the primary fine-tuned-SDK reference doc) has several code samples that would raise real exceptions if copy-pasted, verified against the actual kumo-sdk source at the pinned/current tag (v2.22.0):
No behavior change to any already-correct sample - the Trainer.load()/Trainer.load_from_tags() lines in Async Jobs and Persistence were already accurate and are untouched.