fix: correct fabricated TrainingTable methods in iterate-model skill - #84
Closed
9Olive wants to merge 1 commit into
Closed
fix: correct fabricated TrainingTable methods in iterate-model skill#849Olive wants to merge 1 commit into
9Olive wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing: Automated internal-consistency review (cross-checked against the repo's own authoritative docs; a few SDK-surface claims spot-checked against installed kumoai 2.22.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skills/iterate-model.mdrecommendedtrain_table.label_distribution()andtrain_table.count()(Step 4's data-quality table, and the Common Errors table) to diagnose class imbalance and row counts. Neither method exists onTrainingTable— confirmed againstkumoai/pquery/training_table.pyin kumo-sdk, whose only public methods aredata_urls,data_df,export, andupdate. This is the same fabricated-method pattern already fixed incontext/platform/sdk-overview.mdby #80 (which established the correct.data_df()-based replacement pattern), just missed in this file.Replaced with the pandas-based pattern already used elsewhere in this repo (and in #80):
train_table.data_df()["target_col"].value_counts()for class-distribution andlen(train_table.data_df())for row counts.3-line diff, no other changes.