-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1679): add auto refresh to container logs #4640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FR-1679): add auto refresh to container logs #4640
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.7% | 548/11648 |
| 🔴 | Branches | 3.81% | 314/8250 |
| 🔴 | Functions | 2.91% | 104/3571 |
| 🔴 | Lines | 4.65% | 530/11391 |
Test suite run success
125 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 879081b
1f39760 to
0355b24
Compare
0355b24 to
579480c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an auto-refresh feature to the container log modal with a configurable refresh interval. Users can toggle auto-refresh on/off and set their preferred interval using a TimePicker. The implementation refactors the existing AutoRefreshSwitch component to be more flexible and stores user preferences persistently.
Key changes:
- Enhanced
AutoRefreshSwitchto accept interval and other props as configurable parameters - Added auto-refresh controls with TimePicker to the container log modal
- Persisted auto-refresh preferences (enabled state and interval) in user settings
- Added i18n support for "Auto refresh" across all supported languages
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| react/src/components/AutoRefreshSwitch.tsx | Refactored to accept interval and switch props, making the component more flexible and reusable |
| react/src/components/ComputeSessionNodeItems/ContainerLogModal.tsx | Added auto-refresh UI controls with TimePicker and integrated with user settings |
| react/src/hooks/useBAISetting.tsx | Added TypeScript interface properties for storing auto-refresh preferences |
| resources/i18n/*.json | Added "AutoRefresh" translation key in all 20 supported language files |
react/src/components/ComputeSessionNodeItems/ContainerLogModal.tsx
Outdated
Show resolved
Hide resolved
react/src/components/ComputeSessionNodeItems/ContainerLogModal.tsx
Outdated
Show resolved
Hide resolved
react/src/components/ComputeSessionNodeItems/ContainerLogModal.tsx
Outdated
Show resolved
Hide resolved
yomybaby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It doesn't work correctly on the first activation. You can reproduce this by clearing the relevant
localStoragekeys and trying again. - Instead of using a
TimePicker, what do you think about accepting just a single number representing seconds?
579480c to
dab66f2
Compare
|
Oops, I didn't use autoRefreshIntervalValue in below. Thanks! |
dab66f2 to
2528469
Compare
2528469 to
6a783b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 24 out of 24 changed files in this pull request and generated no new comments.
00ce91c to
38f1cb8
Compare
6a783b4 to
1822856
Compare
yomybaby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1822856 to
5dca640
Compare
Merge activity
|
resolves FR-1679 # Add auto-refresh feature to container logs with configurable interval This PR enhances the container log modal with an auto-refresh feature that allows users to automatically refresh logs at configurable intervals. Users can toggle auto-refresh on/off and set their preferred refresh interval using a time picker. The implementation includes: - Enhanced `AutoRefreshSwitch` component to accept additional props and use a configurable interval - Added auto-refresh controls to the container log modal with a time picker for interval selection - Stored user preferences for auto-refresh settings in user settings - Added internationalization support for "Auto refresh" text in all language files <img width="312" height="53" alt="image" src="https://github.com/user-attachments/assets/eb5cd40f-d030-44dc-990f-84bc55003443" /> **Checklist:** - [x] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
5dca640 to
879081b
Compare

resolves FR-1679
Add auto-refresh feature to container logs with configurable interval
This PR enhances the container log modal with an auto-refresh feature that allows users to automatically refresh logs at configurable intervals. Users can toggle auto-refresh on/off and set their preferred refresh interval using a time picker.
The implementation includes:
AutoRefreshSwitchcomponent to accept additional props and use a configurable intervalChecklist: