Skip to content

Conversation

@agatha197
Copy link
Contributor

@agatha197 agatha197 commented Nov 14, 2025

resolves FR-1679

Add auto-refresh feature to container logs with configurable interval

This PR enhances the container log modal with an auto-refresh feature that allows users to automatically refresh logs at configurable intervals. Users can toggle auto-refresh on/off and set their preferred refresh interval using a time picker.

The implementation includes:

  • Enhanced AutoRefreshSwitch component to accept additional props and use a configurable interval
  • Added auto-refresh controls to the container log modal with a time picker for interval selection
  • Stored user preferences for auto-refresh settings in user settings
  • Added internationalization support for "Auto refresh" text in all language files
image

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copilot AI review requested due to automatic review settings November 14, 2025 05:58
@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:M 30~100 LoC labels Nov 14, 2025
Copy link
Contributor Author

agatha197 commented Nov 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot finished reviewing on behalf of agatha197 November 14, 2025 06:00
@agatha197 agatha197 requested review from ironAiken2, kyujin-cho, nowgnuesLee and yomybaby and removed request for Copilot November 14, 2025 06:00
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.7% 548/11648
🔴 Branches 3.81% 314/8250
🔴 Functions 2.91% 104/3571
🔴 Lines 4.65% 530/11391

Test suite run success

125 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 879081b

@agatha197 agatha197 requested a review from Beomi November 14, 2025 06:01
@agatha197 agatha197 marked this pull request as draft November 14, 2025 06:43
@agatha197 agatha197 force-pushed the feat_FR-1679_/add-auto-refresh-to-container-logs branch 2 times, most recently from 1f39760 to 0355b24 Compare November 17, 2025 02:58
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Nov 17, 2025
@agatha197 agatha197 force-pushed the feat_FR-1679_/add-auto-refresh-to-container-logs branch from 0355b24 to 579480c Compare November 17, 2025 02:59
@agatha197 agatha197 marked this pull request as ready for review November 17, 2025 03:00
Copilot AI review requested due to automatic review settings November 17, 2025 03:00
Copilot finished reviewing on behalf of agatha197 November 17, 2025 03:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an auto-refresh feature to the container log modal with a configurable refresh interval. Users can toggle auto-refresh on/off and set their preferred interval using a TimePicker. The implementation refactors the existing AutoRefreshSwitch component to be more flexible and stores user preferences persistently.

Key changes:

  • Enhanced AutoRefreshSwitch to accept interval and other props as configurable parameters
  • Added auto-refresh controls with TimePicker to the container log modal
  • Persisted auto-refresh preferences (enabled state and interval) in user settings
  • Added i18n support for "Auto refresh" across all supported languages

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.

File Description
react/src/components/AutoRefreshSwitch.tsx Refactored to accept interval and switch props, making the component more flexible and reusable
react/src/components/ComputeSessionNodeItems/ContainerLogModal.tsx Added auto-refresh UI controls with TimePicker and integrated with user settings
react/src/hooks/useBAISetting.tsx Added TypeScript interface properties for storing auto-refresh preferences
resources/i18n/*.json Added "AutoRefresh" translation key in all 20 supported language files

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It doesn't work correctly on the first activation. You can reproduce this by clearing the relevant localStorage keys and trying again.
  • Instead of using a TimePicker, what do you think about accepting just a single number representing seconds?

@agatha197 agatha197 force-pushed the feat_FR-1679_/add-auto-refresh-to-container-logs branch from 579480c to dab66f2 Compare November 18, 2025 13:24
Copy link
Contributor Author

Oops, I didn't use autoRefreshIntervalValue in below. Thanks!

@agatha197 agatha197 changed the base branch from main to graphite-base/4640 November 18, 2025 13:37
@agatha197 agatha197 force-pushed the feat_FR-1679_/add-auto-refresh-to-container-logs branch from dab66f2 to 2528469 Compare November 18, 2025 13:37
@agatha197 agatha197 changed the base branch from graphite-base/4640 to fix/FR-1634 November 18, 2025 13:37
@agatha197 agatha197 force-pushed the feat_FR-1679_/add-auto-refresh-to-container-logs branch from 2528469 to 6a783b4 Compare November 18, 2025 13:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 24 out of 24 changed files in this pull request and generated no new comments.

Copilot finished reviewing on behalf of agatha197 November 18, 2025 13:47
@yomybaby yomybaby changed the base branch from fix/FR-1634 to graphite-base/4640 November 19, 2025 02:51
@yomybaby yomybaby force-pushed the feat_FR-1679_/add-auto-refresh-to-container-logs branch from 6a783b4 to 1822856 Compare November 19, 2025 02:51
@yomybaby yomybaby changed the base branch from graphite-base/4640 to main November 19, 2025 02:51
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the feat_FR-1679_/add-auto-refresh-to-container-logs branch from 1822856 to 5dca640 Compare November 19, 2025 02:53
@graphite-app
Copy link

graphite-app bot commented Nov 19, 2025

Merge activity

resolves FR-1679

# Add auto-refresh feature to container logs with configurable interval

This PR enhances the container log modal with an auto-refresh feature that allows users to automatically refresh logs at configurable intervals. Users can toggle auto-refresh on/off and set their preferred refresh interval using a time picker.

The implementation includes:

- Enhanced `AutoRefreshSwitch` component to accept additional props and use a configurable interval
- Added auto-refresh controls to the container log modal with a time picker for interval selection
- Stored user preferences for auto-refresh settings in user settings
- Added internationalization support for "Auto refresh" text in all language files

<img width="312" height="53" alt="image" src="https://github.com/user-attachments/assets/eb5cd40f-d030-44dc-990f-84bc55003443" />

**Checklist:**

- [x] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app bot force-pushed the feat_FR-1679_/add-auto-refresh-to-container-logs branch from 5dca640 to 879081b Compare November 19, 2025 02:59
@graphite-app graphite-app bot merged commit 879081b into main Nov 19, 2025
11 checks passed
@graphite-app graphite-app bot deleted the feat_FR-1679_/add-auto-refresh-to-container-logs branch November 19, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants