feat(FR-1634): Configure Copilot to accept 'use memo' React directive #4667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
agatha197
changed the base branch from
feat_FR-1679_/add-auto-refresh-to-container-logs
to
graphite-base/4667
agatha197
force-pushed
the
fix/FR-1634
branch
from
7790fed to
00ce91c
Compare
agatha197
force-pushed
the
graphite-base/4667
branch
from
dab66f2 to
72a98ab
Compare
agatha197
force-pushed
the
fix/FR-1634
branch
from
00ce91c to
5a328a6
Compare
Copilot finished reviewing on behalf of
agatha197
November 19, 2025 04:04
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the React Compiler documentation in the GitHub instructions, focusing on clarifying the intentional use of the use memo directive and preventing developers from removing it due to tooling warnings.
Key Changes:
- Added comprehensive guidance on React Compiler directives (
use memo,use client) with explicit warnings not to remove them despite IDE warnings - Reorganized documentation with improved spacing and structure throughout all sections
- Added a new "Code style for React files" section explaining proper directive placement
Merge activity
|
…#4667) resolves FR-1634 # Enhance React Compiler Documentation and Best Practices This PR significantly expands the React Compiler documentation, particularly around the `use memo` directive. It clarifies that: - The project uses React Compiler with directives like `use memo` and `use client` - These directives are intentional and valid even if tooling shows warnings - Developers should not remove or "fix" these directives The PR adds detailed guidance on: - When and how to use React directives - Proper code style for React files - How to handle React directives in components Additionally, the documentation formatting has been improved throughout with better spacing and organization of bullet points. **Checklist:** - [x] Documentation AI: I've created a pull request description that focuses specifically on the changes made to the React Compiler documentation. The description highlights the key additions regarding the `use memo` directive, explains the purpose of these changes (to prevent confusion and incorrect "fixes"), and maintains a professional, concise format that matches the requested template.
graphite-app
bot
force-pushed
the
fix/FR-1634
branch
from
5a328a6 to
1b46ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves FR-1634
Enhance React Compiler Documentation and Best Practices
This PR significantly expands the React Compiler documentation, particularly around the
use memodirective. It clarifies that:use memoanduse clientThe PR adds detailed guidance on:
Additionally, the documentation formatting has been improved throughout with better spacing and organization of bullet points.
Checklist:
AI: I've created a pull request description that focuses specifically on the changes made to the React Compiler documentation. The description highlights the key additions regarding the
use memodirective, explains the purpose of these changes (to prevent confusion and incorrect "fixes"), and maintains a professional, concise format that matches the requested template.