chore: adopt bambamboole/extended-testbench for the package tooling - #16
Merged
Conversation
The bridge makes Boost work under Testbench out of the box, which replaces the hand-rolled overrides in workbench/app/Support that pointed Boost's config, guideline and skill composers at the package root. Aligns the repo with what its package:init scaffolds: - Pest 4 -> 5, abandoned mrpunyapal/peststan -> pestphp/pest-plugin-phpstan, added rector/rector. Dropped the explicit orchestra/testbench constraint; the bridge requires ^11. - artisan symlink -> the committed PHP shim. - phpunit.xml -> phpunit.xml.dist (plus a Unit suite and the env block), phpstan.neon -> phpstan.neon.dist (plus database/), new rector.php. - Scripts renamed to the generated shape: lint, stan, refactor, check. test stays scoped to Unit+Feature so check never pulls in the Browser suite, which needs a built bundle and a browser. - pint.json drops the blank_line_after_opening_tag override, which is the blank-line-only churn across ~60 files. - .gitignore and .gitattributes reconciled with the generated entries. - .ai/guidelines/git.md and the Comments section of development.md are now shipped by the package and registered via boost.json's packages key. rector.php skips two rules: RemoveUnusedPublicMethodParameterRector, which strips the model argument Laravel's Gate passes to policy methods, and FlipTypeControlToUseExclusiveTypeRector, which rewrites null checks as inline fully-qualified instanceof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts
bambamboole/extended-testbench ^0.3and aligns the repo with the setup itspackage:initscaffolds.The bridge makes Boost work under Testbench out of the box, so the hand-rolled overrides in
workbench/app/Support— which pointed Boost's config, guideline and skill composers at the package root — are gone, along with.ai/guidelines/git.mdand the Comments section ofdevelopment.md, both now shipped by the package and registered viaboost.json'spackageskey.Tooling
mrpunyapal/peststan→pestphp/pest-plugin-phpstan; addedrector/rector. Dropped the explicitorchestra/testbenchconstraint (the bridge requires^11).artisansymlink → the committed PHP shim.phpunit.xml→phpunit.xml.dist(+Unitsuite, env block);phpstan.neon→phpstan.neon.dist(+database/); newrector.php.lint,stan,refactor,check.teststays scoped toUnit,Featuresochecknever pulls in the Browser suite, which needs a built bundle and a browser..gitignore/.gitattributesreconciled with the generated entries.Two deliberate rector skips
RemoveUnusedPublicMethodParameterRectorstrips the model argument Laravel's Gate passes to policy methods;FlipTypeControlToUseExclusiveTypeRectorrewrites null checks as inline fully-qualifiedinstanceof. Reasons are inrector.php.Reviewing: ~60 of the 80 files are blank-line-only churn from dropping the
blank_line_after_opening_tagoverride inpint.json— use?w=1to hide it. The substantive diff is 23 files.Verified:
composer check(Pint, PHPStan, Rector, 143 Pest),composer test:browser(9),npm run typecheck && npm test(39).