Document backup storage config in README - #1414
Merged
Merged
Conversation
The README documented a backup_storage path key, which was replaced by the backup storage config block in #792. Unknown yaml keys are ignored, so configs using backup_storage silently ran without a backup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Devin Review: 2 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
boks1971
approved these changes
Sep 28, 2026
Failover is tracked per output uploader, not per egress. The prefix is only a local directory when no provider is set; the handler runs with working directory /, so it resolves from /. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1413.
The README still documented
backup_storage: <path>, but that key was replaced bybackup(a full storage config, same shape asstorage) in #792 (v1.9.0). Config parsing ignores unknown yaml keys, so a config usingbackup_storageruns with no backup and logs nothing.Changes:
backup_storageline.backupblock: same fields asstorage, used after the first failed primary upload for the rest of that egress, and written to the local filesystem (relative to the working directory, joined withprefix) when no provider is set.🤖 Generated with Claude Code