feat(WebAssembly): Make WebAssembly.Global generic#963
Merged
sandersn merged 4 commits intomicrosoft:mainfrom Apr 24, 2023
Merged
feat(WebAssembly): Make WebAssembly.Global generic#963sandersn merged 4 commits intomicrosoft:mainfrom
WebAssembly.Global generic#963sandersn merged 4 commits intomicrosoft:mainfrom
Conversation
1 task
ghost
reviewed
Jan 15, 2021
ghost
reviewed
Jan 15, 2021
f9eecea to
3bd4988
Compare
Member
|
The types look like an improvement to me. @saschanaz would it be better to fix this upstream somewhere instead of overriding it here? If not I think this would be appropriate here. |
Collaborator
|
The IDL syntax does not support this kind of generics, so I think we need to override them. Looks good to me, feel free to merge 👍 |
sandersn
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
WebAssembly.Globalgeneric to better match the runtime behaviour:Q: Should I change this to use something more like: