fix: split MOBB_EXEC from MOBB_ARGS for test tooling compatibility [E-1815]#34
Open
jonathansantilli wants to merge 1 commit intomainfrom
Open
fix: split MOBB_EXEC from MOBB_ARGS for test tooling compatibility [E-1815]#34jonathansantilli wants to merge 1 commit intomainfrom
jonathansantilli wants to merge 1 commit intomainfrom
Conversation
The autofixer CI uses sed to replace `npx --yes mobbdev@latest` with `API_URL=http://... node .../dist/index.mjs` in action.yml. With a single MOBB_ARGS array, the sed replacement puts `API_URL=... node .../index.mjs` as part of the first array element, and `env` treats the whole thing as one var assignment instead of separating the env var from the command. Splitting into MOBB_EXEC (the npx command, sed-replaceable) and MOBB_ARGS (the flags/arguments) ensures that after sed replacement, `env` correctly handles `API_URL=...` as a var and `node` as the command. Ref: E-1815
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the autofixer CI test failure caused by PR #33.
Splits the command array into two parts:
MOBB_ARGS=(review -r ... --ref ...), the flags and argumentsExecution:
env "${MOBB_EXEC[@]}" "${MOBB_ARGS[@]}"Root Cause
The autofixer test uses
sedto replacenpx --yes mobbdev@latestwithAPI_URL=http://... node .../dist/index.mjs. With a single array, the replacement becomes one element andenvtreats the whole thing as a single var assignment. With two arrays,envcorrectly separatesAPI_URL=...(var),node(command), and the rest (args).Test plan